Hi Mark, running checkstyle and findbugs as part of the build is a good idea... I'll look into that.
Andreas On Wed, Apr 3, 2013 at 11:07 PM, Mark Fortner <[email protected]> wrote: > I was wishing I could just kibitz on some of the code without having to > actually fix it. :-) > > Just some odd things I noticed in FastaReader and FastaWriter where the > code contains a main instead of relying on the test case to give you an > example. And comments that are partial or missing. > > Are the checkstyle and findbugs plugins configured to run as part of the > build? > > Mark > On Apr 3, 2013 10:58 PM, "Spencer Bliven" <[email protected]> wrote: > >> Mark– >> >> If you commit to your own fork and then create a pull request, it >> automatically gives you a place for code review. >> >> You could also open up an issue. >> https://github.com/biojava/biojava/issues >> >> -Spencer >> >> >> On Wed, Apr 3, 2013 at 5:22 PM, Mark Fortner <[email protected]> wrote: >> >>> Great job you guys. I've already spotted some minor things. If only I >>> could figure out a way to do a code review without doing a commit. :-) >>> >>> Cheers, >>> >>> Mark >>> >>> >>> >>> On Wed, Apr 3, 2013 at 5:03 PM, Andreas Prlic <[email protected]> wrote: >>> >>>> Thanks Spencer for all your efforts in getting this set up! I hope that >>>> will make the code base even more accessible and should provide a path >>>> of >>>> submitting patches more easily from now on. >>>> >>>> Let the social coding begin! >>>> >>>> Andreas >>>> >>>> >>>> On Wed, Apr 3, 2013 at 4:32 PM, Spencer Bliven <[email protected]> >>>> wrote: >>>> >>>> > The transition to Github is now finished, although we're still >>>> working on >>>> > getting the documentation up-to-date. If you're currently using a >>>> checkout >>>> > of trunk from SVN, that checkout will still work but will not receive >>>> any >>>> > future updates. Please follow the instructions at >>>> > http://biojava.org/wiki/Get_source to get a copy of the latest >>>> source from >>>> > git. >>>> > >>>> > The documentation is rather confusing at the moment, with references >>>> to the >>>> > old SVN interspersed with recent git instructions. If you run into >>>> such a >>>> > situation on the wiki, please fix it or mark the article with the >>>> > {{outdated}} template so we can get the documentation back up to par. >>>> > >>>> > Thanks! >>>> > Spencer >>>> > >>>> > >>>> > On Tue, Mar 26, 2013 at 10:35 AM, Spencer Bliven <[email protected]> >>>> wrote: >>>> > >>>> > > Dear community, >>>> > > >>>> > > On the developer list we have been discussing moving the biojava >>>> code to >>>> > > github for some time. This transition is currently scheduled to >>>> occur >>>> > this >>>> > > weekend. For users who get Biojava via binary jars or maven, this >>>> will >>>> > have >>>> > > no effect on your projects. Users who compile the latest version of >>>> the >>>> > > source themselves may have to get a fresh version from github after >>>> > April 1: >>>> > > >>>> > > biojava 3: https://github.com/biojava/biojava >>>> > > biojava 1: https://github.com/biojava/biojava-legacy >>>> > > >>>> > > I'll be working on improving documentation for the transition this >>>> week. >>>> > > For those interested in the migration process, see >>>> > > http://biojava.org/wiki/SVN_to_GIT_Migration. Some information >>>> about >>>> > > using git with eclipse is at >>>> > > http://biojava.org/wiki/BioJava3_eclipse#Anonymous_access_with_Git. >>>> And >>>> > > http://biojava.org/wiki/Get_source will soon be updated with the >>>> new >>>> > > instructions for getting the latest source code from git. >>>> > > >>>> > > Please let me know if anyone has suggestions or concerns. >>>> > > >>>> > > -Spencer >>>> > > >>>> > _______________________________________________ >>>> > Biojava-l mailing list - [email protected] >>>> > http://lists.open-bio.org/mailman/listinfo/biojava-l >>>> > >>>> _______________________________________________ >>>> Biojava-l mailing list - [email protected] >>>> http://lists.open-bio.org/mailman/listinfo/biojava-l >>>> >>> >>> >> _______________________________________________ Biojava-l mailing list - [email protected] http://lists.open-bio.org/mailman/listinfo/biojava-l
