I *think* I have answered my own question.  The patch in the email doesn't
include the switch to xmalloc that was originally in
the krt-export-filtr-fix branch as well.

I can see from `git blame` that it's in the previous commit,
bc00f058154bb4a630d24d64a55b5f181d235c63  [ Filter: Prefer xmalloc/xfree to
malloc/free ].

So, it looks like I actually need a290da25a16b7c79d4a7a87f522b4068bca04979
and bc00f058154bb4a630d24d64a55b5f181d235c63.

Can you please confirm this is correct ?
Or else advise the best way to patch against the current release ?



Cheers,
Just

On 19 September 2016 at 10:41, Justin Cattle <j...@ocado.com> wrote:

> Ok - great.
>
> Should this patch apply to the 1.6 released version ok ?
> I was tracking from the krt-export-filtr-fix before, that that is now gone
> :)
>
>
>
>
> Cheers,
> Just
>
> On 19 September 2016 at 10:13, Ondrej Zajicek <santi...@crfreenet.org>
> wrote:
>
>> On Mon, Sep 19, 2016 at 09:46:03AM +0100, Justin Cattle wrote:
>> > Hi Pavel,
>> >
>> >
>> > After running with this latest fixup commit for a week, I see mixed
>> results.
>> >
>> > With the first fix you created, all the processes remained using a very
>> > small amount of memory, consistently.  As per my previous email, around
>> > 80Mg.
>> > With the second fix, some of the bird processes are using up to about
>> > 600Mg, but some are still using more like the 80Mg from the first fix.
>> > And, there is a mixture in between those two extremes.
>> >
>> > So my question is  - is this normal and expected now, of is there a
>> > potential issue with the second fix?
>>
>> Hi
>>
>> We found that there was one minor leak that was overlooked in the second
>> fix.
>>
>> You can try attached patch v3.
>>
>> --
>> Elen sila lumenn' omentielvo
>>
>> Ondrej 'Santiago' Zajicek (email: santi...@crfreenet.org)
>> OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
>> "To err is human -- to blame it on a computer is even more so."
>>
>
>

-- 


Notice:  This email is confidential and may contain copyright material of 
members of the Ocado Group. Opinions and views expressed in this message 
may not necessarily reflect the opinions and views of the members of the 
Ocado Group. 

 

If you are not the intended recipient, please notify us immediately and 
delete all copies of this message. Please note that it is your 
responsibility to scan this message for viruses. 

 

Fetch and Sizzle are trading names of Speciality Stores Limited and Fabled 
is a trading name of Marie Claire Beauty Limited, both members of the Ocado 
Group.

 

References to the “Ocado Group” are to Ocado Group plc (registered in 
England and Wales with number 7098618) and its subsidiary undertakings (as 
that expression is defined in the Companies Act 2006) from time to time. 
 The registered office of Ocado Group plc is Titan Court, 3 Bishops Square, 
Hatfield Business Park, Hatfield, Herts. AL10 9NE.

Reply via email to