Hi,

The user interface to the push parser currently looks like this:

int
yyparse (void)
{
  struct yypvars *ctx = yypvarsinit ();
  int status;
  do {
    yychar_set (ctx, yylex ());
    yylval_set (ctx, yylval);
#ifdef YYLTYPE_IS_TRIVIAL
    yylloc_set (ctx, yylloc);
#endif
    yypushparse (ctx);
    status = yyresult_get (ctx);
  } while (status == 4);
  free (ctx);
  return status;
}

In particular, I don't like this line:
  } while (status == 4);

The number 4 should be put in either a #define, or a function call.
Which one is preferable? The #define would probably be more efficient.
If so, what would be a good name?

Thanks,
Bob Rossi


Reply via email to