>> "make maintainer-check-valgrind" has a lot of failures still, but I >> assume more patches will come later? > > I had no failures after my original patch. I'll review this one later.
I had similar failures both with your original patch, and with my revised one. I am using Debian stable x86, which has valgrind-2.4.0 and flex 2.5.31. I have installed GCC 4.1.1 myself. Here's the first failure (with CVS bison right now): $ cd tests $ VALGRIND_OPTS='--leak-check=full --show-reachable=yes' ./testsuite -v -d PREBISON='valgrind -q' PREPARSER='valgrind -q' 3 ## --------------------------- ## ## GNU Bison 2.3a+ test suite. ## ## --------------------------- ## 3. input.at:162: testing ... ./input.at:163: bison input.y --- - 2006-11-09 00:11:38.154693000 -0800 +++ /home/eggert/src/gnu/bison/tests/testsuite.dir/at-stderr 2006-11-09 00:11:38.000000000 -0800 @@ -23,4 +23,33 @@ input.y:21.10-68: warning: unset value: $$ input.y:21.10-68: warning: unused value: $1 input.y:21.10-68: warning: unused value: $2 +==20200== +==20200== 4 bytes in 1 blocks are still reachable in loss record 1 of 3 +==20200== at 0x1B90659D: malloc (vg_replace_malloc.c:130) +==20200== by 0x806479A: skel_ensure_buffer_stack (scan-skel.c:1775) +==20200== by 0x8065484: skel_lex (scan-skel.c:869) +==20200== by 0x8065611: scan_skel (scan-skel.l:123) +==20200== by 0x80528C0: output_skeleton (output.c:580) +==20200== by 0x8056162: output (output.c:658) +==20200== by 0x804E2A5: main (main.c:162) +==20200== +==20200== +==20200== 4 bytes in 1 blocks are still reachable in loss record 2 of 3 +==20200== at 0x1B90659D: malloc (vg_replace_malloc.c:130) +==20200== by 0x805FD4A: gram_ensure_buffer_stack (scan-gram.c:2889) +==20200== by 0x8060788: gram_lex (scan-gram.c:1218) +==20200== by 0x8057DF3: gram_parse (parse-gram.c:1809) +==20200== by 0x805B97B: reader (reader.c:596) +==20200== by 0x804E147: main (main.c:85) +==20200== +==20200== +==20200== 36 bytes in 1 blocks are still reachable in loss record 3 of 3 +==20200== at 0x1B90706F: realloc (vg_replace_malloc.c:196) +==20200== by 0x805DAB6: code_ensure_buffer_stack (scan-code.c:1927) +==20200== by 0x805DBAC: code__switch_to_buffer (scan-code.c:1660) +==20200== by 0x805F720: translate_action (scan-code.l:391) +==20200== by 0x805F817: translate_symbol_action (scan-code.l:408) +==20200== by 0x8058DDF: gram_parse (parse-gram.y:269) +==20200== by 0x805B97B: reader (reader.c:596) +==20200== by 0x804E147: main (main.c:85) 3. input.at:162: FAILED (input.at:163) ## ------------- ## ## Test results. ## ## ------------- ## ERROR: 1 test was run, 1 failed unexpectedly. ## -------------------------- ## ## testsuite.log was created. ## ## -------------------------- ## Please send `tests/testsuite.log' and all information you think might help: To: <[email protected]> Subject: [GNU Bison 2.3a+] testsuite: 3 failed
