From: Chris Larson <[email protected]>
Signed-off-by: Chris Larson <[email protected]>
---
TODO | 1 -
lib/bb/msg.py | 13 +++++++++++++
2 files changed, 13 insertions(+), 1 deletions(-)
diff --git a/TODO b/TODO
index 26aecf7..e978427 100644
--- a/TODO
+++ b/TODO
@@ -20,7 +20,6 @@
- Audit bb.fatal usage - these should all be able to be replaced with
exceptions
-- Add deprecation warnings to the bb.msg functions
- Figure out how to handle the ncurses UI. Should some of our logging
formatting stuff be made common to all of bitbake, or perhaps all UIs via
the UIHelper?
diff --git a/lib/bb/msg.py b/lib/bb/msg.py
index 098b0dc..0a8d7de 100644
--- a/lib/bb/msg.py
+++ b/lib/bb/msg.py
@@ -26,6 +26,7 @@ import sys
import logging
import collections
from itertools import groupby
+import warnings
import bb
import bb.event
@@ -107,6 +108,8 @@ def set_debug_domains(domainargs):
#
def debug(level, msgdomain, msg, fn = None):
+ warnings.warn("bb.msg.debug will soon be deprecated in favor of the python
'logging' module",
+ PendingDeprecationWarning, stacklevel=2)
level = logging.DEBUG - (level - 1)
if not msgdomain:
logger.log(level, msg)
@@ -114,9 +117,13 @@ def debug(level, msgdomain, msg, fn = None):
loggers[msgdomain].log(level, msg)
def plain(msg, fn = None):
+ warnings.warn("bb.msg.plain will soon be deprecated in favor of the python
'logging' module",
+ PendingDeprecationWarning, stacklevel=2)
logger.log(logging.INFO + 1, msg)
def note(level, msgdomain, msg, fn = None):
+ warnings.warn("bb.msg.note will soon be deprecated in favor of the python
'logging' module",
+ PendingDeprecationWarning, stacklevel=2)
level = logging.INFO - (level - 1)
if not msgdomain:
logger.log(level, msg)
@@ -124,18 +131,24 @@ def note(level, msgdomain, msg, fn = None):
loggers[msgdomain].log(level, msg)
def warn(msgdomain, msg, fn = None):
+ warnings.warn("bb.msg.warn will soon be deprecated in favor of the python
'logging' module",
+ PendingDeprecationWarning, stacklevel=2)
if not msgdomain:
logger.warn(msg)
else:
loggers[msgdomain].warn(msg)
def error(msgdomain, msg, fn = None):
+ warnings.warn("bb.msg.error will soon be deprecated in favor of the python
'logging' module",
+ PendingDeprecationWarning, stacklevel=2)
if not msgdomain:
logger.error(msg)
else:
loggers[msgdomain].error(msg)
def fatal(msgdomain, msg, fn = None):
+ warnings.warn("bb.msg.fatal will soon be deprecated in favor of raising
appropriate exceptions",
+ PendingDeprecationWarning, stacklevel=2)
if not msgdomain:
logger.critical(msg)
else:
--
1.7.2.1.66.g0d0ba
_______________________________________________
Bitbake-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/bitbake-dev