Agreed.

On Wed, Sep 1, 2010 at 10:19 AM, Bernhard Reutner-Fischer <
[email protected]> wrote:

> On Wed, Aug 18, 2010 at 07:34:50PM -0700, Chris Larson wrote:
>
>
> Given that fn in all functions below is not handled and that this led to
> wrong output (i.e. real bugs) i'd like to remove them if you didn't
> already, ok?
>
> thanks,
> > #
> > # Message handling functions
> > #
> >
> > def debug(level, msgdomain, msg, fn = None):
> >+    level = logging.DEBUG - (level - 1)
> >     if not msgdomain:
> >-        msgdomain = domain.Default
> >+        logger.log(level, msg)
> >+    else:
> >+        loggers[msgdomain].log(level, msg)
> >
> >-    if debug_level[msgdomain] >= level:
> >-        bb.event.fire(MsgDebug(msg), None)
> >-        if not bb.event._ui_handlers:
> >-            print('DEBUG: %s' % (msg))
> >+def plain(msg, fn = None):
> >+    logger.log(logging.INFO + 1, msg)
> >
> > def note(level, msgdomain, msg, fn = None):
> >+    level = logging.INFO - (level - 1)
> >     if not msgdomain:
> >-        msgdomain = domain.Default
> >-
> >-    if level == 1 or verbose or debug_level[msgdomain] >= 1:
> >-        bb.event.fire(MsgNote(msg), None)
> >-        if not bb.event._ui_handlers:
> >-            print('NOTE: %s' % (msg))
> >+        logger.log(level, msg)
> >+    else:
> >+        loggers[msgdomain].log(level, msg)
> >
> > def warn(msgdomain, msg, fn = None):
> >-    bb.event.fire(MsgWarn(msg), None)
> >-    if not bb.event._ui_handlers:
> >-        print('WARNING: %s' % (msg))
> >+    if not msgdomain:
> >+        logger.warn(msg)
> >+    else:
> >+        loggers[msgdomain].warn(msg)
> >
> > def error(msgdomain, msg, fn = None):
> >-    bb.event.fire(MsgError(msg), None)
> >-    print('ERROR: %s' % (msg))
> >+    if not msgdomain:
> >+        logger.error(msg)
> >+    else:
> >+        loggers[msgdomain].error(msg)
> >
> > def fatal(msgdomain, msg, fn = None):
> >-    bb.event.fire(MsgFatal(msg), None)
> >-    print('FATAL: %s' % (msg))
> >+    if not msgdomain:
> >+        logger.critical(msg)
> >+    else:
> >+        loggers[msgdomain].critical(msg)
> >     sys.exit(1)
> >-
> >-def plain(msg, fn = None):
> >-    bb.event.fire(MsgPlain(msg), None)
> >-    if not bb.event._ui_handlers:
> >-        print(msg)
> _______________________________________________
> Bitbake-dev mailing list
> [email protected]
> https://lists.berlios.de/mailman/listinfo/bitbake-dev
>



-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
_______________________________________________
Bitbake-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/bitbake-dev

Reply via email to