On Mon, Dec 17, 2018 at 10:18:40PM -0500, Russell O'Connor wrote: > On Mon, Dec 17, 2018 at 3:16 PM Johnson Lau <jl2...@xbt.hk> wrote: > But I’m not sure if that would do more harm than good. For example, people > might lose money by copying an existing script template. But they might > also lose money in the same way as CHECKMULTISIG is disabled. So I’m not > sure.
Well, if CHECKSIG* and CHECKMULTISIG* are all disabled in favour of CHECKDLS, CHECKDLSVERIFY and CHECKDLSADD with both different names and different opcodes, copying a script template opcode-for-opcode from v0 to v1 will always fail. (With taproot, this doesn't necessarily mean you lose money, even if the script is impossible to ever satisfy, since you may be able to recover via the direct signature path) > Another related thing I’d like to bikeshed is to pop the stack after > OP_CLTV and OP_CSV. The same pros and cons apply. > This one is almost a no-brainer I think. Nearly every instance of OP_CSV is > followed by an OP_DROP and we'd save 1 WU per OP_CSV if we pop the stack > afterwards. It's definitely bikeshedding so whatever; but to me, it seems like it'd be easier for everyone to have it so that if you've got the same opcode in v0 script and v1.0 script; they have precisely the same semantics. (That said, constructions like "<n> CLTV <p> CHECKSIGVERIFY" that avoid the DROP and work when you're expected to leave a true value on the stack won't work if you have to end up with an empty stack) Cheers, aj _______________________________________________ bitcoin-dev mailing list firstname.lastname@example.org https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev