tree 73f299aaed1e5a9a5c2e9b826352c46391df40fc
parent 981e23ba7ad8d8889372389dc235282cab4f9d24
author Andi Kleen <[EMAIL PROTECTED]> Tue Apr 12 08:25:40 2005
committer Linus Torvalds <[EMAIL PROTECTED]> Tue Apr 12 08:25:40 2005
[PATCH] x86_64: Remove excessive stack allocation in MCE code with large NR_CPUS
Remove excessive stack allocation in MCE code with large NR_CPUS
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
mce.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletion(-)
Index: arch/x86_64/kernel/mce.c
===================================================================
--- 05591ce0f5fe495976edf362f4692a96432540cb/arch/x86_64/kernel/mce.c
(mode:100644 sha1:9f9d955f37697570cddacac611d3df5d89271634)
+++ 73f299aaed1e5a9a5c2e9b826352c46391df40fc/arch/x86_64/kernel/mce.c
(mode:100644 sha1:609994e7de06b823bd30ea53d84a03420f7103a3)
@@ -379,18 +379,23 @@
static ssize_t mce_read(struct file *filp, char __user *ubuf, size_t usize,
loff_t *off)
{
- unsigned long cpu_tsc[NR_CPUS];
+ unsigned long *cpu_tsc;
static DECLARE_MUTEX(mce_read_sem);
unsigned next;
char __user *buf = ubuf;
int i, err;
+ cpu_tsc = kmalloc(NR_CPUS * sizeof(long), GFP_KERNEL);
+ if (!cpu_tsc)
+ return -ENOMEM;
+
down(&mce_read_sem);
next = rcu_dereference(mcelog.next);
/* Only supports full reads right now */
if (*off != 0 || usize < MCE_LOG_LEN*sizeof(struct mce)) {
up(&mce_read_sem);
+ kfree(cpu_tsc);
return -EINVAL;
}
@@ -421,6 +426,7 @@
}
}
up(&mce_read_sem);
+ kfree(cpu_tsc);
return err ? -EFAULT : buf - ubuf;
}
-
To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
