tree 7518c84cce4de43dad5809246fa2e740b895d317
parent b9188157e2d6de6eeaf2d2c898fd65d33e643f72
author Russell King <[EMAIL PROTECTED]> Tue Apr 12 08:27:06 2005
committer Linus Torvalds <[EMAIL PROTECTED]> Tue Apr 12 08:27:06 2005

[PATCH] serial: fix comments in 8250.c

Fix the formatting of some comments in 8250.c, and add a note that the
register_serial / unregister_serial shouldn't be used in new code.

We do this here in preference to adding to linux/serial.h, since that is used
by a number of non-8250 drivers which pretend to be 8250.  It is not known
whether it would be appropriate to do so.

Signed-off-by: Russell King <[EMAIL PROTECTED]>

Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>

 8250.c |   14 +++++++++++---
 1 files changed, 11 insertions(+), 3 deletions(-)

Index: drivers/serial/8250.c
===================================================================
--- 5511098a1284aad33f7492eb1ab816a54c758369/drivers/serial/8250.c  
(mode:100644 sha1:f651ee27c70b6ca56a1d5eb2bacd1d96bfa20b95)
+++ 7518c84cce4de43dad5809246fa2e740b895d317/drivers/serial/8250.c  
(mode:100644 sha1:1b7e0d4861929d1fc24ff4a4c86a15eddc914a65)
@@ -1065,8 +1065,10 @@
                                tty_flip_buffer_push(tty);
                                spin_lock(&up->port.lock);
                        }
-                       /* If this failed then we will throw away the
-                          bytes but must do so to clear interrupts */
+                       /*
+                        * If this failed then we will throw away the
+                        * bytes but must do so to clear interrupts
+                        */
                }
                ch = serial_inp(up, UART_RX);
                flag = TTY_NORMAL;
@@ -1106,7 +1108,7 @@
                                up->port.icount.overrun++;
 
                        /*
-                        * Mask off conditions which should be ingored.
+                        * Mask off conditions which should be ignored.
                         */
                        lsr &= up->port.read_status_mask;
 
@@ -2570,6 +2572,9 @@
  *     If this fails an error is returned.
  *
  *     On success the port is ready to use and the line number is returned.
+ *
+ *     Note: this function is deprecated - use serial8250_register_port
+ *     instead.
  */
 int register_serial(struct serial_struct *req)
 {
@@ -2624,6 +2629,9 @@
  *
  *     Remove one serial port.  This may not be called from interrupt
  *     context.  We hand the port back to our local PM control.
+ *
+ *     Note: this function is deprecated - use serial8250_unregister_port
+ *     instead.
  */
 void unregister_serial(int line)
 {
-
To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to