tree 074c1411c6c53cb32787588263abbd04f760b610
parent bcd9f02a5b45ae6abd3f70f6146042e5a7aeab3c
author NeilBrown <[EMAIL PROTECTED]> Tue Apr 12 08:27:04 2005
committer Linus Torvalds <[EMAIL PROTECTED]> Tue Apr 12 08:27:04 2005
[PATCH] nfsd4: callback create rpc client returns
rpc_create_clnt and friends return errors, not NULL, on failure.
Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]>
Signed-off-by: Neil Brown <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
nfs4callback.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
Index: fs/nfsd/nfs4callback.c
===================================================================
--- e7923d6e0ff4afab9c625e2844d6ae71adf68ddd/fs/nfsd/nfs4callback.c
(mode:100644 sha1:18b81208ee173bd5485619fe7abce1248b2e5f5f)
+++ 074c1411c6c53cb32787588263abbd04f760b610/fs/nfsd/nfs4callback.c
(mode:100644 sha1:8903fd7677515501d67bbb994d133795fa602f04)
@@ -405,7 +405,8 @@
timeparms.to_exponential = 1;
/* Create RPC transport */
- if (!(xprt = xprt_create_proto(IPPROTO_TCP, &addr, &timeparms))) {
+ xprt = xprt_create_proto(IPPROTO_TCP, &addr, &timeparms);
+ if (IS_ERR(xprt)) {
dprintk("NFSD: couldn't create callback transport!\n");
goto out_err;
}
@@ -426,7 +427,8 @@
* XXX AUTH_UNIX only - need AUTH_GSS....
*/
sprintf(hostname, "%u.%u.%u.%u", NIPQUAD(addr.sin_addr.s_addr));
- if (!(clnt = rpc_create_client(xprt, hostname, program, 1,
RPC_AUTH_UNIX))) {
+ clnt = rpc_create_client(xprt, hostname, program, 1, RPC_AUTH_UNIX);
+ if (IS_ERR(clnt)) {
dprintk("NFSD: couldn't create callback client\n");
goto out_xprt;
}
-
To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
