Archaic pointed out some things. Especially the whitespace thing.
Once you get the XML tools setup and you render, you'd have noticed
this. No big deal.
I used bluefish for my edits. Actually, I was very careful about lining up my columns with tabs. Guess each editor has its own quirks.

Some other notes.

1. In at least one spot, you didn't change the "adding an entry" to
"create the file" when referencing the addition of an inet.d file.
Let me know if I should go back and make these changes and the recreate the patch file again.

2. Why do you end a command with closing [/command] tags, simply to open the very next line with an opening [command tag]? Both can be omitted. I hope this makes sense what I'm saying.
I copied samples from shadow but shadow has </sect> followed by <sect> between each cat command. Chalk this up to learning.

3. In an install command, the -o root and -g root parameters are redundant. Root will be issuing the command and the default is to use root's UID and GID.
I did not touch any install commands so whatever is using -o and -g is already there.

Let me know if I need to rework the patch.

--
http://linuxfromscratch.org/mailman/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page

Reply via email to