Hi,

As the subject says, this is really just a nitpick - just sharing an
opinion in case anyone else feels the same.

The sed for Firefox in BLFS SVN could be tuned down a little. IMHO, the
spaces make it difficult to see clearly what's going on there. In fact
the first set of four spaces aren't necessary to find the string. I
understand the desire to keep the indendation on the newly inserted line
and so the second set of 4 spaces isn't so bothersome, however, they're
not really necessary, either.

The sed could be chopped down to:

sed -i 's|="$moz"|&\n run_moz="$dist_bin/mozilla.sh"|' \
browser/app/mozilla.in

possibly even smaller.

--
JH
-- 
http://linuxfromscratch.org/mailman/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page

Reply via email to