On 3/20/06, Randy McMurchy <[EMAIL PROTECTED]> wrote:
>
> That is why it says "If you installed any CODECs, ensure you add
> --with-codecsdir=/usr/lib/mplayer/codecs to the configure script."
> immediately following the installation of the CODECs. :-)
>
> I'm sure you just overlooked it.

Seems right to my.  I never had problems with it.

> >>The reason for this is that the configure script
> >>generates an "-O4" switch in the config.mak. This is useless because the
> >>highest optimization flag supported by GCC is "-O3".
>
> The sed sounds like a good idea.

I'm not certain, but doesn't gcc use the highest optimization (O3) if
any higher number is given?  I'd have to test that, but if it's true,
the sed would be useless.

Also, if you have CFLAGS set at configure time, MPlayer respects that.
 Does for me, anyway.  So, that would make the mention of setting
CFLAGS unnecessary since it would be just like any normal package that
checks CFLAGS at configure time.

> >>3. Further we should use the configure switch "--disable-ossaudio"
> >>because OSS is deprecated AFAIK.
>
> It may be deprecated, but who are we to tell people what to use and
> what not to use?

I agree with Randy here.  We shouldn't explicitly disable OSS since
some people might want it.  However, I'd appreciate if it was
mentioned in the Command Explanations.  If no one feels like doing
that, I can add the text in.

> >>CFLAGS= ./configure --prefix=/usr --confdir=/etc/mplayer
> >>--with-codecsdir=/usr/lib/mplayer/codecs \
> >>    --enable-largefiles --disable-ossaudio &&
> >>sed -i "[EMAIL PROTECTED]@-O3@" config.mak &&

If I'm wrong about -O4 becoming -O3, then you can just change the
value in configure.

sed -i 's/-O3/-O4/' configure

There's no reason to pass null CFLAGS to configure.  It does exactly
what it's supposed to.  If CFLAGS aren't set, you get what the
developer thinks.  If they are set, you get what you want.

--
Dan
--
http://linuxfromscratch.org/mailman/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page

Reply via email to