Qrux wrote:
> Looks good. You were more precise about where you performed the
> loop--and it seems to make more sense. I'll try them out as soon as
> I can.
>
> This is a usage point, but I'm not sure that having ifconfig.eth0 and
> encouraging people to set ONBOOT=no when it's part of a bridge makes
> sense. In other systems, the precedent seems to be to omit the
> ifconfig.<BRIDGE_PORT> entries entirely, to avoid massive
> confusion--and possibly a conflict--when someone forgets ONBOOT, and
> the machine loses outside network connectivity. Could be annoying
> when it's a server at a colo...
> The bridge script takes care of bringing the eth0 link up and taking
> it down, so ifconfig.eth0 shouldn't need to exist.
That was only for you guys and testing, not the book.
> I didn't think ipv4-static needed modifying, unless it was cosmetic.
> Would you mind giving a quick summary of the change you made there?
--- ipv4-static (revision 9714)
+++ ipv4-static (working copy)
@@ -42,8 +42,13 @@
case "${2}" in
up)
- if [ "$(ip addr show ${1} | grep ${IP})" == "" ]; then
- log_info_msg2 "\n" # Terminate the previous message
+ if [ "$(ip addr show ${1} 2>/dev/null | grep ${IP})" == "" ]; then
+
+ # Cosmetic output not needed for multiple services
+ if ! $(echo ${SERVICE} | grep -q " "); then
+ log_info_msg2 "\n" # Terminate the previous message
+ fi
@@ -64,7 +69,7 @@
;;
down)
- if [ "$(ip addr show ${1} | grep ${IP})" != "" ]; then
+ if [ "$(ip addr show ${1} 2>/dev/null | grep ${IP})" != "" ]; then
@@ -72,7 +77,7 @@
- if [ "$(ip addr show ${1} | grep 'inet ')" != "" ]; then
+ if [ "$(ip addr show ${1} 2>/dev/null | grep 'inet ')" != "" ]; then
ip addr show gives an error if the interface doesn't exist.
> It looks like you look for spaces in ipv4-static to determine if
> there are multiple services. For robustness's (LOL) sake, maybe
> sanitize first with:
>
> $(echo ${SERVICE} | sed s'/\s\+/ /g' | grep -q " ")?
>
> Somewhat minor, though I'm sure someone somewhere has used a tab in a
> spaced-out moment...
I was going to write it up as space delimited.
--
http://linuxfromscratch.org/mailman/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
