On Mon, Dec 09, 2019 at 04:19:12PM +0100, Alain Dumont via blfs-dev wrote: > Hi All, > > In the instructions for Qtwebengine you propose to use the instruction > NINJAJOBS = x to avoid some problems. > This variable, defined in the Ninja patch of LFS collides with the present > variable in ../src/core/gn_run.pro of the qtwebengine package, > which causes strange compilation errors. >
Examples, please. > alain [ ~/Public/prog/unpack/qtwebengine-everywhere-src-5.13.2 ]$ grep -R > NINJAJOBS * > src/core/gn_run.pro: runninja.commands = $$NINJA $$ninjaflags > \$\(NINJAJOBS\) -C $$gn_build_root QtWebEngineCore > I've used NINJAJOBS for several (5.12) builds on my laptop where I have 8 cores but less than 8GB RAM, and I haven't seen any errors from setting this. Looking at both 5.13.2 nd 5.12.6, the only reference is in 5.13.2, as you show above. But there is no indication of what one might expect to see in that variable. ĸen > > That's why I propose to replace in the LFS patch of ninja, the variable > NINJAJOBS by NINJACORES. > Indeed, if we examine the patched function in the ninja source code, > this function calculates the number of processors by default (cores) rather > than the number of jobs it can perform. > It therefore seems more judicious to call this variable NINJACORES rather > than NINJAJOBS. > > Bye > Alain > -- > http://lists.linuxfromscratch.org/listinfo/blfs-dev > FAQ: http://www.linuxfromscratch.org/blfs/faq.html > Unsubscribe: See the above information page -- We've all got both light and dark inside of us. What matters is the part we choose to act on. -- Sirius Black -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
