On 12/9/19 2:22 PM, Alain Dumont via blfs-dev wrote:
Le 09/12/2019 à 20:20, Ken Moffat via blfs-dev a écrit :
On Mon, Dec 09, 2019 at 04:19:12PM +0100, Alain Dumont via blfs-dev
wrote:
Hi All,
In the instructions for Qtwebengine you propose to use the instruction
NINJAJOBS = x to avoid some problems.
This variable, defined in the Ninja patch of LFS collides with the
present
variable in ../src/core/gn_run.pro of the qtwebengine package,
which causes strange compilation errors.
Examples, please.
alain [ ~/Public/prog/unpack/qtwebengine-everywhere-src-5.13.2 ]$
grep -R
NINJAJOBS *
src/core/gn_run.pro: runninja.commands = $$NINJA $$ninjaflags
\$\(NINJAJOBS\) -C $$gn_build_root QtWebEngineCore
I've used NINJAJOBS for several (5.12) builds on my laptop where I have
8 cores but less than 8GB RAM, and I haven't seen any errors from
setting this.
Looking at both 5.13.2 nd 5.12.6, the only reference is in 5.13.2,
as you show above. But there is no indication of what one might
expect to see in that variable.
ĸen
That's why I propose to replace in the LFS patch of ninja, the variable
NINJAJOBS by NINJACORES.
Indeed, if we examine the patched function in the ninja source code,
this function calculates the number of processors by default (cores)
rather
than the number of jobs it can perform.
It therefore seems more judicious to call this variable NINJACORES
rather
than NINJAJOBS.
I found it useful to report this bug because I was a victim on one of
my machines (intel / 4 cores / 8GB ram).
Unable to compile QtWebEngine, I had to recompile Ninja by modifying
the patch to indicate NINJACORES.
This solved my problem. But now with my new Ninja suitably patched, I
can not reproduce this bug anymore.
I remember, however, that the error messages mentioned NINJAJOBS
explicitly, and it was precisely because of this that I was able to
identify the source of the problem.
Alain
I have encountered a different problem before with the variable
substitution. What happens is that, under "run_ninja:" in
src/core/Makefile.gn_run, it puts in "ninja -v 1" (assuming NINJAJOBS is
set to 1, which on my dual core systems is set), instead of "ninja -v -j
1". However, I think this is a problem in QtWebEngine's build system and
not ninja. I don't know how to troubleshoot it further though, I've
always just modified it to allow it to function whenever it breaks.
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
