On 12/10/19 4:01 PM, Pierre Labastie via blfs-dev wrote:
Le 10/12/2019 à 16:50, Douglas R. Reno via blfs-dev a écrit :
On 12/9/19 10:49 PM, Douglas R. Reno via blfs-dev wrote:
On 2019-12-09 22:45, Bruce Dubbs via blfs-dev wrote:
On 12/9/19 2:53 PM, Pierre Labastie via blfs-dev wrote:
Le 09/12/2019 à 21:33, Douglas R. Reno via blfs-dev a écrit :
On Sun, Dec 8, 2019, 11:52 AM Bruce Dubbs via blfs-dev
<[email protected]
<mailto:[email protected]>> wrote:
On 12/8/19 7:33 AM, Pierre Labastie via blfs-dev wrote:
> I did the bisection, and found that the commit which changed the
behavior in
> meson is 3db6dcb3b85.
>
> I Filed an issue[1] with meson, but they may as well tell that
mutter devs
> should change their meson.build files.
>
> For now, I suggest disabling the cogl_tests, or maybe issue this sed:
>
> sed -e 's@[./]*dev/stdout @@' \
> -e 's@meson-private/coredata.dat @@' \
> -i build.ninja
>
> after running meson and before running ninja. coredata.dat must
also be
> removed, because it appears to be posterior to build.ninja, so
that meson is
> run again when ninja starts, and the effect of the sed is lost...
>
> Pierre
> [1]: https://github.com/mesonbuild/meson/issues/6315
It is interesting that the type of redirection matters. If I do:
meson --prefix=/usr -Dprofiler=false .. > file.log
then stdout shows up in build.ninja. If I do:
meson --prefix=/usr -Dprofiler=false .. 2>&1 | tee file.log
stdout is not found in build.ninja. I guess I never saw the problem
since my scripts use tee.
To me, the problem is definitely in meson. The output should never
change for something that bash does.
-- Bruce
Hi guys,
Should we backport the fix in meson in the form of a sed?
https://github.com/xclaesse/meson/commit/a25708368ea4dc2ba4ab89682981b28411f913ae
I'm not sure what their release schedule is.
Only found this: https://mesonbuild.com/Release-procedure.html
The sed can be:
sed "s@isfile(f)@& and not f.startswith('/dev')@" -i
mesonbuild/interpreter.py
Note that double quotes are required, since we want to add single quotes...
That sed is easy enough to add and then remove when the next version
is released. Doug, do you want to do it?
One minor issue, my personal taste is to use | as the alternate sed
delimiter, but I can live with @.
sed -i "s|isfile(f)|& and not f.startswith('/dev')|" \
mesonbuild/interpreter.py
(two lines only because of email wrapping)
-- Bruce
Hi Bruce,
Yeah I can do it, I'll have it in in the morning, going to start a jhalfs
run for it before I go to bed to make sure it doesn't break systemd's build
process
- Doug
Fixed at r11708 :)
Arrgh, I've just found that there is nowhere isfile(f) in
meson-0.52.1/mesonbuild/interpreter.py. The fix above is for master!
I think the proper fix is the same sed, but with "a" instead of "f":
sed -i "s|isfile(a)|& and not a.startswith('/dev')|" \
mesonbuild/interpreter.py
But this is not anymore upstream's fix... At least, it fixes the issue with
mutter. I suggest to use this sed for now, and see whether upstream releases
something before our release in March (according to their doc, they should
make a release every month or so.
OK, Fixed at revision 11709.
-- Bruce
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
