On Mon, Feb 10, 2020 at 09:56:55PM +0100, Uwe Düffert via blfs-dev wrote:
> On Sat, 8 Feb 2020, Ken Moffat via blfs-dev wrote:
> 
> > For you, easy.  For me, I can just about realise that poppler is the
> > problem.  So, whenever you find it is easy enough to fix, please can
> > you report what you did ?  TIA.
> I'll try to remember that. Whenever I did not, I usually had a reason - a
> mixture of: It seemed hacky even to me. It only considered my use-case
> (here: only considers most recent poppler while a decent patch would have
> some IFDEF POPPLERVERSION>X around it). I did not check whether upstream
> already has a (just not released) solution. "Easy enough to fix" may also
> mean: I just skipped two versions of it but kept my script unchanged and
> only took a deeper look into it and came up with a patch two months later
> after editors long decided to go another way. Usually you guys are faster
> and more informed than me and I appreciate that ;-)
> 

For the hacky ifdefs, I note that fedora did similar for
poppler-0.83.0 (and supposedly 0.84.0 was already ok).  But yeah, my
own upgrades to new builds are now much less frequent than they used
to be.

And I very much agree that the details of LO configury can be hard
to follow.  But any suggestions are always welcome.

> That said, inkscape-0.92.4 has a very similar issue as libreoffice-6.4.0.3
> which I solved by the seds below. This is close to but not identical to what
> the book does. The globalParams and const parts are better solved by the
> upstream patch, but the Unicode sed did not work for me with all the latest
> packages such as poppler-0.85 and I needed mine instead:
> 
> sed -e 's/globalParams = new GlobalParams()/globalParams.reset(new
> GlobalParams())/' -i src/extension/internal/pdfinput/pdf-input.cpp
> 
> sed -e 's/(GfxPath/(const GfxPath/' \
>  -e 's/  GfxSubpath/  const GfxSubpath/' \
>  -i src/extension/internal/pdfinput/svg-builder.cpp
> 
> sed -e 's/(GfxPath/(const GfxPath/' \
>  -e 's/  &u/  (const Unicode**)\&u/' \
>  -i src/extension/internal/pdfinput/pdf-parser.cpp
> 
> Regards
> Uwe

Hmm, I didn't have any problem with inkscape last week.  Maybe my
script has diverged from the book (apart from the obvious changes to
use my own CFLAGS and CXXFLAGS throughout).

ĸen
-- 
We had folksingers in the lower bar for six months back home where
I worked.  In the end we had to get a man in with a ferret.
                   -- Polly, in "Interesting Times"
-- 
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page

Reply via email to