Ken Moffat wrote:
On Sat, Mar 11, 2017 at 10:59:52PM -0600, Bruce Dubbs wrote:
Ken Moffat wrote:
On both the AMD machines, no problem. But on both of the intel
machines, I ended up with a symlink pointing to libnssckbi.so.orig
(still works, but rather defeats the point of it). What I don't
understand is why. I've now manually fixed them, but I'm still
struggling to work out what I've overlooked.
My code is slightly different:
if [ -h /usr/lib/libnssckbi.so ]; then
echo "libnssckbi.so is already a symlink, nothing to do"
else
echo "making libnssckbi.so a symlink to libp11-kit.so"
mv -v /usr/lib/libnssckbi.so /usr/lib/libnssckbi.so.orig
ln -sfv libp11-kit.so /usr/lib/libnssckbi.so
fi
[---]
It looks like the instructions work, but I don't like them. I'd prefer to
see:
if [ ! -h /usr/lib/libnssckbi.so ]; then
mv -v /usr/lib/libnssckbi.so /usr/lib/libnssckbi.so.orig
ln -sfv libp11-kit.so /usr/lib/libnssckbi.so
fi
Which is a slightly less verbose verion of what you have.
Two reasons:
1. In the "do nothing" case (i.e. a later upgrade of certs on a
system where I have already done this) I want to see something in my
log to tell me if it did anything. Probably I could have put a test
in the "driver" scripts which invokes this (upgrade firefox, update
certs, build that part of my desktop where I build firefox) but I
didn't. Of course, doing that would not give me a log at all.
2. My 'client' scripts (build a package, install a bootscript, in
this case decide whether or not to make a symlink) fail on non-zero
status. 'If' tests withut an 'else' tend to provoke such failures
when the test is not met.
For some things in firefox (conditional tests which can lead to me
adding, or not adding, things to _my_ default build, e.g. I only
add the current sed for libevent if the version is suitable) I _do_
turn off the 'set' whilst doing the tests, but it can get messy and
I prefer not to do that.
Sure. I was not talking about your scripts. I was referring to the
instructions in the book.
-- Bruce
--
http://lists.linuxfromscratch.org/listinfo/blfs-support
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
