LGTM3

On 2022-05-11 07:37, Mike West wrote:
LGTM2.

-mike


On Tue, May 10, 2022 at 12:37 AM Mike Taylor <[email protected]> wrote:

    Hey Mustaq - welcome back. :)

    Thanks for the answers, and for requesting the missing WebKit
    position.

    LGTM1

    On 5/9/22 5:04 PM, Mustaq Ahmed wrote:
    Hi Mike:

    Sorry for the delay due to vacation etc! Below are my answers
    to your queries.  Note that we are still asking for M103, so we
    will be prompt now :)

    > Does this only work for standard requestFullscreen, or will it
    work for webkitRequestFullscreen as well?

    This covers all forms: we are proposing changes in the core
    algorithm for request-fullscreen, regardless of the JS interface
    used to call it.

    >> Gecko: Positive
    (https://github.com/mozilla/standards-positions/issues/565, also
    see: https://github.com/WICG/capability-delegation/issues/10)
    > I don't think these quite count as official Positive signals
    (but yes, the comments from Anne are promising!). Can we ping the
    standards-position issue and ask for one?

    See the recent comments in the issue asking for Gecko's position,
    thanks.
    https://github.com/mozilla/standards-positions/issues/565

    >> WebKit: No signal
    > Have we asked? I looked at the Payment Request, and it seems
    like we didn't, but maybe I'm looking in the wrong spot. If not,
    can we?

    I missed this with the intent for payment, sorry! Filed a single
    request to cover both payment and fullscreen capabilities:
    https://lists.webkit.org/pipermail/webkit-dev/2022-May/032221.html

    >> Is this feature fully tested by web-platform-tests?
    >> Not yet
    > Is there something missing to test this (or capability
    detection in general), or is it just that you haven't written the
    WPTs yet?

    We hadn't written a WPT at that time.  We have one under review now:
    https://github.com/web-platform-tests/wpt/pull/34004

    Mustaq


    On Sun, May 8, 2022 at 11:07 PM Ajay Rahatekar
    <[email protected]> wrote:

        +Ajay Rahatekar

        On Monday, April 25, 2022 at 12:29:29 PM UTC-7
        [email protected] wrote:

            Hi Mustaq,

            On 4/21/22 11:05 AM, Mustaq Ahmed wrote:


                    Contact emails

            [email protected], [email protected]


                    Explainer

            https://github.com/WICG/capability-delegation
            <https://github.com/WICG/capability-delegation>


                    Specification

            https://wicg.github.io/capability-delegation/spec.html
            <https://wicg.github.io/capability-delegation/spec.html>

            (Work in progress for fullscreen algorithm change:
            https://github.com/WICG/capability-delegation/pull/28
            <https://github.com/WICG/capability-delegation/pull/28>)


                    Design doc

            
https://docs.google.com/document/d/1ax54Lf2W3_TovVOj35duKTbcOlXe-nJ-KQdWiy1Ye0c
            
<https://docs.google.com/document/d/1ax54Lf2W3_TovVOj35duKTbcOlXe-nJ-KQdWiy1Ye0c>


                    Summary

            This feature is based on the general delegation
            mechanism
            (https://chromestatus.com/feature/5708770829139968
            <https://chromestatus.com/feature/5708770829139968>)
            shipped on M100.


            Fullscreen Capability Delegation allows a Window to
            transfer the ability to call requestFullscreen() to
            another Window it trusts after relinquishing the
            transient user activation at the sender Window.

            Does this only work for standard requestFullscreen, or
            will it work for webkitRequestFullscreen as well?


                    Blink component

            Blink>Fullscreen
            
<https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EFullscreen>


                    TAG review

            Covered by the review for the general delegation
            mechanism:
            https://github.com/w3ctag/design-reviews/issues/655
            <https://github.com/w3ctag/design-reviews/issues/655>


                    TAG review status

            Covered by the approval for the general delegation
            mechanism:https://github.com/WICG/capability-delegation/pull/23
            <https://github.com/WICG/capability-delegation/pull/23>


                    Risks

            Interoperability and Compatibility risks remain
            unchanged from the general delegation mechanism; see
            that intent here:
            
https://groups.google.com/a/chromium.org/g/blink-dev/c/PHT_2X7oRBE/m/gR9UiZxBAQAJ
            
<https://groups.google.com/a/chromium.org/g/blink-dev/c/PHT_2X7oRBE/m/gR9UiZxBAQAJ>


                    External signals

            Gecko:Positive
            (https://github.com/mozilla/standards-positions/issues/565
            <https://github.com/mozilla/standards-positions/issues/565>,
            also see:
            https://github.com/WICG/capability-delegation/issues/10
            <https://github.com/WICG/capability-delegation/issues/10>)

            I don't think these quite count as official Positive
            signals (but yes, the comments from Anne are promising!).
            Can we ping the standards-position issue and ask for one?

            WebKit:No signal

            Have we asked? I looked at the Payment Request, and it
            seems like we didn't, but maybe I'm looking in the wrong
            spot. If not, can we?

            Web developers:Positive (https://crbug.com/931966#c5
            <https://crbug.com/931966#c5>)


                    Debuggability

            This remains unchanged from the general intent:
            
https://groups.google.com/a/chromium.org/g/blink-dev/c/PHT_2X7oRBE/m/gR9UiZxBAQAJ
            
<https://groups.google.com/a/chromium.org/g/blink-dev/c/PHT_2X7oRBE/m/gR9UiZxBAQAJ>


                    Ongoing technical constraints

            None.


                    Will this feature be supported on all six Blink
                    platforms (Windows, Mac, Linux, Chrome OS,
                    Android, and Android WebView)?

            Yes


                    Is this feature fully tested by
                    web-platform-tests
                    
<https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md>?

            Not yet

            Is there something missing to test this (or capability
            detection in general), or is it just that you haven't
            written the WPTs yet?


                    Flag name

            --enable-blink-features=CapabilityDelegationFullscreenRequest


                    Requires code in //chrome?

            Yes, work in progress


                    Tracking bug

            https://crbug.com/1293083 <https://crbug.com/1293083>


                    Estimated milestone

            103


                    Link to entry on the Chrome Platform Status

            https://chromestatus.com/feature/6441688242323456
            <https://chromestatus.com/feature/6441688242323456>


                    Links to previous Intent discussions

            Intents for the general delegation mechanism:

             *

                I2P:
                
https://groups.google.com/a/chromium.org/g/blink-dev/c/9CeLYndESPE/m/AhEttheMBQAJ
                
<https://groups.google.com/a/chromium.org/g/blink-dev/c/9CeLYndESPE/m/AhEttheMBQAJ>

             *

                I2E (with Payment Request):
                
https://groups.google.com/a/chromium.org/g/blink-dev/c/i6pAWsjU7zg/m/UK0lGnKuAAAJ
                
<https://groups.google.com/a/chromium.org/g/blink-dev/c/i6pAWsjU7zg/m/UK0lGnKuAAAJ>

            I2S (with Payment Request):
            
https://groups.google.com/a/chromium.org/g/blink-dev/c/PHT_2X7oRBE/m/gR9UiZxBAQAJ
            
<https://groups.google.com/a/chromium.org/g/blink-dev/c/PHT_2X7oRBE/m/gR9UiZxBAQAJ>
-- You received this message because you are subscribed to
            the Google Groups "blink-dev" group.
            To unsubscribe from this group and stop receiving emails
            from it, send an email to [email protected].
            To view this discussion on the web visit
            
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAB0cuO63mt3wbrDHhy7ieb4yAwd0YNhmQM11Mdg3eXfhpt558g%40mail.gmail.com
            
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAB0cuO63mt3wbrDHhy7ieb4yAwd0YNhmQM11Mdg3eXfhpt558g%40mail.gmail.com?utm_medium=email&utm_source=footer>.



-- You received this message because you are subscribed to the Google
    Groups "blink-dev" group.
    To unsubscribe from this group and stop receiving emails from it,
    send an email to [email protected].
    To view this discussion on the web visit
    
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f4a6af83-56b0-f390-10d0-be7cd9d12780%40chromium.org
    
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f4a6af83-56b0-f390-10d0-be7cd9d12780%40chromium.org?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3DeSAWS83NVoHJUhn2pAViA8pMogmcx5CcBWHvL2BHeY6A%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3DeSAWS83NVoHJUhn2pAViA8pMogmcx5CcBWHvL2BHeY6A%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/af03ccfe-20fb-5e4b-bef7-e045061c8413%40gmail.com.

Reply via email to