The failing tests have now been fixed<https://chromium-review.googlesource.com/c/chromium/src/+/3651546/>. Thanks for the quick review Chris ! Now that this is done, can you please tell me what the process would look like to get this ON in stable? I have a CL for this<https://chromium-review.googlesource.com/c/chromium/src/+/3690356> but I assume you'd want to run experiments first?
Thanks, Rahul From: Yoav Weiss <yoavwe...@chromium.org> Sent: Wednesday, June 1, 2022 2:10 PM To: Chris Harrelson <chris...@chromium.org> Cc: Mike Taylor <miketa...@chromium.org>; Ben Mathwig <benjamin.math...@microsoft.com>; Rahul Arakeri <arak...@microsoft.com>; blin...@chromium.org <blink-dev@chromium.org>; inpu...@chromium.org <input-...@chromium.org>; Olga Gerchikov <gerch...@microsoft.com>; Mike Jackson (EDGE) <mjack...@microsoft.com>; Ben Mathwig <benjamin.math...@microsoft.com>; Diego Gonzalez <luigo...@microsoft.com>; Amanda Baker <amanda.ba...@microsoft.com>; jsb...@google.com <jsb...@google.com>; Ajay Rahatekar <ajayrahate...@google.com>; Hassan Talat <hassan.ta...@microsoft.com>; wangxianzhu <wangxian...@chromium.org>; Philip Rogers <p...@chromium.org>; Robert Flack <fla...@chromium.org>; Emilio Cobos Alvarez <emi...@mozilla.com> Subject: [EXTERNAL] Re: [blink-dev] Re: Intent To Ship: Prevent fixed elements from moving during elastic overscroll. LGTM3 On Wed, Jun 1, 2022 at 11:07 PM Chris Harrelson <chris...@chromium.org<mailto:chris...@chromium.org>> wrote: Spec text<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fw3c%2Fcsswg-drafts%2Fcommit%2F617c50c35a90535ab1ecbcf3adff4c281d91b43b&data=05%7C01%7Carakeri%40microsoft.com%7C40712752088f4455706608da441404f0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637897150030154018%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=J%2FSra0uXVB2dSkiq8NmuWmKYDSZv%2Bq54CsrO%2BZJW5Dk%3D&reserved=0>. On Wed, Jun 1, 2022 at 1:13 PM Mike Taylor <miketa...@chromium.org<mailto:miketa...@chromium.org>> wrote: Thanks Chris. LGTM2. On 6/1/22 1:26 PM, Chris Harrelson wrote: A spec edit is indeed needed. However, I think it's a one-liner. I pinged the editor of the spec just now about it. LGTM1 to ship; I'll make sure that the spec commit lands via my CSSWG hat. On Wed, Jun 1, 2022 at 12:45 AM Yoav Weiss <yoavwe...@chromium.org<mailto:yoavwe...@chromium.org>> wrote: Thanks for the explainer. My question regarding a spec still stands :) On Friday, May 27, 2022 at 10:49:31 PM UTC+2 Chris Harrelson wrote: Ah yes! That counts, and saves filing a signal. Thanks Emilio! On Fri, May 27, 2022 at 1:46 PM Emilio Cobos Álvarez <emi...@mozilla.com<mailto:emi...@mozilla.com>> wrote: On 5/27/22 20:40, Chris Harrelson wrote: > No. it has to be done via the > https://bit.ly/blink-signals<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbit.ly%2Fblink-signals&data=05%7C01%7Carakeri%40microsoft.com%7C40712752088f4455706608da441404f0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637897150030154018%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=P1XBbOhYnoCQe7u7ajvifUkfElcgm4TX8ShViybDGlo%3D&reserved=0> > <https://bit.ly/blink-signals<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbit.ly%2Fblink-signals&data=05%7C01%7Carakeri%40microsoft.com%7C40712752088f4455706608da441404f0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637897150030154018%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=P1XBbOhYnoCQe7u7ajvifUkfElcgm4TX8ShViybDGlo%3D&reserved=0>> > process, because otherwise we might > accidentally misconstrue their true organizational positions. FWIW in case it saves some time, we're actively working on this in <https://bugzilla.mozilla.org/show_bug.cgi?id=1760368<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.mozilla.org%2Fshow_bug.cgi%3Fid%3D1760368&data=05%7C01%7Carakeri%40microsoft.com%7C40712752088f4455706608da441404f0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637897150030154018%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=V%2BcgP%2BbolsjoF95Krt1Ru2SusPWL3hszBTQiKKYKB7U%3D&reserved=0>>. -- Emilio -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org<mailto:blink-dev%2bunsubscr...@chromium.org>. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/5f816069-432f-b85a-4abc-ada3ea0dc71f%40mozilla.com<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fa%2Fchromium.org%2Fd%2Fmsgid%2Fblink-dev%2F5f816069-432f-b85a-4abc-ada3ea0dc71f%2540mozilla.com&data=05%7C01%7Carakeri%40microsoft.com%7C40712752088f4455706608da441404f0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637897150030154018%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=J3aE2K%2BZ7ld6J94vkzW7M0YadG0z03mzO%2FvEZnBdfhA%3D&reserved=0>. -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org<mailto:blink-dev+unsubscr...@chromium.org>. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/4191983d-d0fd-4dce-beed-d12ee7115a46n%40chromium.org<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fa%2Fchromium.org%2Fd%2Fmsgid%2Fblink-dev%2F4191983d-d0fd-4dce-beed-d12ee7115a46n%2540chromium.org%3Futm_medium%3Demail%26utm_source%3Dfooter&data=05%7C01%7Carakeri%40microsoft.com%7C40712752088f4455706608da441404f0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637897150030154018%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=g%2FR8NcUW%2Bp1D3jiQxXN5nIxPjqGoK%2B0%2F6UPMDtPuYtk%3D&reserved=0>. -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org<mailto:blink-dev+unsubscr...@chromium.org>. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9OX%3D3dPBwC3ARwiL6GMSx%3DASY5EiEMOPC5e4S0iJUcWA%40mail.gmail.com<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fa%2Fchromium.org%2Fd%2Fmsgid%2Fblink-dev%2FCAOMQ%252Bw9OX%253D3dPBwC3ARwiL6GMSx%253DASY5EiEMOPC5e4S0iJUcWA%2540mail.gmail.com%3Futm_medium%3Demail%26utm_source%3Dfooter&data=05%7C01%7Carakeri%40microsoft.com%7C40712752088f4455706608da441404f0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637897150030154018%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=TvM6R3ZK9yTevrqttCEHBtkBcGY2VYjQWe838o0Ymx8%3D&reserved=0>. -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org<mailto:blink-dev+unsubscr...@chromium.org>. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/5efc25ed-0c43-4c7d-e877-d05b6a0512f3%40chromium.org<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fa%2Fchromium.org%2Fd%2Fmsgid%2Fblink-dev%2F5efc25ed-0c43-4c7d-e877-d05b6a0512f3%2540chromium.org%3Futm_medium%3Demail%26utm_source%3Dfooter&data=05%7C01%7Carakeri%40microsoft.com%7C40712752088f4455706608da441404f0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637897150030154018%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=CY4Wer6HsnAr9uUOTh590ikiO31l3IijyFT1UyjbouI%3D&reserved=0>. -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/SJ0PR00MB1141ACDFA8EA11EAF30D96B3A6A29%40SJ0PR00MB1141.namprd00.prod.outlook.com.
