Thanks Daniel, the CL<https://chromium-review.googlesource.com/c/chromium/src/+/3690356> has landed ! Also, I had added a base::Feature flag<https://chromium-review.googlesource.com/c/chromium/src/+/3652981> a couple of weeks ago. I’m assuming that should make it controllable remotely. If not, please let me know.
PS: Thank you all for your reviews on this feature. We appreciate it… 😊 I will keep an eye out for any issues that pop up in the coming days. Thanks, Rahul From: blink-dev@chromium.org <blink-dev@chromium.org> On Behalf Of Daniel Bratell Sent: Wednesday, June 8, 2022 5:34 AM To: Rahul Arakeri <arak...@microsoft.com>; Yoav Weiss <yoavwe...@chromium.org>; Chris Harrelson <chris...@chromium.org> Cc: Mike Taylor <miketa...@chromium.org>; Ben Mathwig <benjamin.math...@microsoft.com>; blin...@chromium.org <blink-dev@chromium.org>; inpu...@chromium.org <input-...@chromium.org>; Olga Gerchikov <gerch...@microsoft.com>; Mike Jackson (EDGE) <mjack...@microsoft.com>; Diego Gonzalez <luigo...@microsoft.com>; Amanda Baker <amanda.ba...@microsoft.com>; jsb...@google.com <jsb...@google.com>; Ajay Rahatekar <ajayrahate...@google.com>; Hassan Talat <hassan.ta...@microsoft.com>; wangxianzhu <wangxian...@chromium.org>; Philip Rogers <p...@chromium.org>; Robert Flack <fla...@chromium.org>; Emilio Cobos Alvarez <emi...@mozilla.com> Subject: Re: [EXTERNAL] Re: [blink-dev] Re: Intent To Ship: Prevent fixed elements from moving during elastic overscroll. You have the approval needed for shipping on stable, i.e. land that patch. It will get some testing by going through Canary and Beta releases, but if you feel some uncertainty you can also add the plumbing that would let it be turned off remotely (flags, finch). You will need some assistance by Google employees for that though. /Daniel On 2022-06-06 07:15, 'Rahul Arakeri' via blink-dev wrote: The failing tests have now been fixed<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F3651546%2F&data=05%7C01%7Carakeri%40microsoft.com%7Cf40bd0628c604c0f3ae408da494b2f42%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637902884543261495%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=LxsVPCWJAtqB1BuLfGLD3%2Fx%2BZ9XdVU5nCy3miWSqxQE%3D&reserved=0>. Thanks for the quick review Chris ! Now that this is done, can you please tell me what the process would look like to get this ON in stable? I have a CL for this<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F3690356&data=05%7C01%7Carakeri%40microsoft.com%7Cf40bd0628c604c0f3ae408da494b2f42%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637902884543261495%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=53oF5v4CvujzWjMy7bSyXnv6rME0WCkwVDySPks37t4%3D&reserved=0> but I assume you’d want to run experiments first? Thanks, Rahul From: Yoav Weiss <yoavwe...@chromium.org><mailto:yoavwe...@chromium.org> Sent: Wednesday, June 1, 2022 2:10 PM To: Chris Harrelson <chris...@chromium.org><mailto:chris...@chromium.org> Cc: Mike Taylor <miketa...@chromium.org><mailto:miketa...@chromium.org>; Ben Mathwig <benjamin.math...@microsoft.com><mailto:benjamin.math...@microsoft.com>; Rahul Arakeri <arak...@microsoft.com><mailto:arak...@microsoft.com>; blin...@chromium.org<mailto:blin...@chromium.org> <blink-dev@chromium.org><mailto:blink-dev@chromium.org>; inpu...@chromium.org<mailto:inpu...@chromium.org> <input-...@chromium.org><mailto:input-...@chromium.org>; Olga Gerchikov <gerch...@microsoft.com><mailto:gerch...@microsoft.com>; Mike Jackson (EDGE) <mjack...@microsoft.com><mailto:mjack...@microsoft.com>; Ben Mathwig <benjamin.math...@microsoft.com><mailto:benjamin.math...@microsoft.com>; Diego Gonzalez <luigo...@microsoft.com><mailto:luigo...@microsoft.com>; Amanda Baker <amanda.ba...@microsoft.com><mailto:amanda.ba...@microsoft.com>; jsb...@google.com<mailto:jsb...@google.com> <jsb...@google.com><mailto:jsb...@google.com>; Ajay Rahatekar <ajayrahate...@google.com><mailto:ajayrahate...@google.com>; Hassan Talat <hassan.ta...@microsoft.com><mailto:hassan.ta...@microsoft.com>; wangxianzhu <wangxian...@chromium.org><mailto:wangxian...@chromium.org>; Philip Rogers <p...@chromium.org><mailto:p...@chromium.org>; Robert Flack <fla...@chromium.org><mailto:fla...@chromium.org>; Emilio Cobos Alvarez <emi...@mozilla.com><mailto:emi...@mozilla.com> Subject: [EXTERNAL] Re: [blink-dev] Re: Intent To Ship: Prevent fixed elements from moving during elastic overscroll. LGTM3 On Wed, Jun 1, 2022 at 11:07 PM Chris Harrelson <chris...@chromium.org<mailto:chris...@chromium.org>> wrote: Spec text<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fw3c%2Fcsswg-drafts%2Fcommit%2F617c50c35a90535ab1ecbcf3adff4c281d91b43b&data=05%7C01%7Carakeri%40microsoft.com%7Cf40bd0628c604c0f3ae408da494b2f42%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637902884543261495%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Y2X4Lp1OT25WVcnyk5coQse1sgcd6hq140Z3WLh0AhE%3D&reserved=0>. On Wed, Jun 1, 2022 at 1:13 PM Mike Taylor <miketa...@chromium.org<mailto:miketa...@chromium.org>> wrote: Thanks Chris. LGTM2. On 6/1/22 1:26 PM, Chris Harrelson wrote: A spec edit is indeed needed. However, I think it's a one-liner. I pinged the editor of the spec just now about it. LGTM1 to ship; I'll make sure that the spec commit lands via my CSSWG hat. On Wed, Jun 1, 2022 at 12:45 AM Yoav Weiss <yoavwe...@chromium.org<mailto:yoavwe...@chromium.org>> wrote: Thanks for the explainer. My question regarding a spec still stands :) On Friday, May 27, 2022 at 10:49:31 PM UTC+2 Chris Harrelson wrote: Ah yes! That counts, and saves filing a signal. Thanks Emilio! On Fri, May 27, 2022 at 1:46 PM Emilio Cobos Álvarez <emi...@mozilla.com<mailto:emi...@mozilla.com>> wrote: On 5/27/22 20:40, Chris Harrelson wrote: > No. it has to be done via the > https://bit.ly/blink-signals<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbit.ly%2Fblink-signals&data=05%7C01%7Carakeri%40microsoft.com%7Cf40bd0628c604c0f3ae408da494b2f42%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637902884543261495%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=aei3jPNne1pAYSunRJOArPQnk8PsAIgEZt3gSWn0y%2B0%3D&reserved=0> > <https://bit.ly/blink-signals<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbit.ly%2Fblink-signals&data=05%7C01%7Carakeri%40microsoft.com%7Cf40bd0628c604c0f3ae408da494b2f42%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637902884543417737%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=z7xJ4RFYYJP6%2B1YjsYGYNvd06zRlo1uGJjQseqSpkAo%3D&reserved=0>> > process, because otherwise we might > accidentally misconstrue their true organizational positions. FWIW in case it saves some time, we're actively working on this in <https://bugzilla.mozilla.org/show_bug.cgi?id=1760368<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.mozilla.org%2Fshow_bug.cgi%3Fid%3D1760368&data=05%7C01%7Carakeri%40microsoft.com%7Cf40bd0628c604c0f3ae408da494b2f42%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637902884543417737%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=iiUSp1rnXwQsnHTLUd9PC5EtikYYUFhMya9F7wBeZ74%3D&reserved=0>>. -- Emilio -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org<mailto:blink-dev%2bunsubscr...@chromium.org>. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/5f816069-432f-b85a-4abc-ada3ea0dc71f%40mozilla.com<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fa%2Fchromium.org%2Fd%2Fmsgid%2Fblink-dev%2F5f816069-432f-b85a-4abc-ada3ea0dc71f%2540mozilla.com&data=05%7C01%7Carakeri%40microsoft.com%7Cf40bd0628c604c0f3ae408da494b2f42%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637902884543417737%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=LNkzgcbknrNb545XJGJeV8oykZCIswiJwKSnx0LFOiY%3D&reserved=0>. -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org<mailto:blink-dev+unsubscr...@chromium.org>. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/4191983d-d0fd-4dce-beed-d12ee7115a46n%40chromium.org<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fa%2Fchromium.org%2Fd%2Fmsgid%2Fblink-dev%2F4191983d-d0fd-4dce-beed-d12ee7115a46n%2540chromium.org%3Futm_medium%3Demail%26utm_source%3Dfooter&data=05%7C01%7Carakeri%40microsoft.com%7Cf40bd0628c604c0f3ae408da494b2f42%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637902884543417737%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2B%2FvA7%2BTOZrC8WmoBbsBrQDCYavNba5syU2c7OOtws9g%3D&reserved=0>. -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org<mailto:blink-dev+unsubscr...@chromium.org>. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9OX%3D3dPBwC3ARwiL6GMSx%3DASY5EiEMOPC5e4S0iJUcWA%40mail.gmail.com<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fa%2Fchromium.org%2Fd%2Fmsgid%2Fblink-dev%2FCAOMQ%252Bw9OX%253D3dPBwC3ARwiL6GMSx%253DASY5EiEMOPC5e4S0iJUcWA%2540mail.gmail.com%3Futm_medium%3Demail%26utm_source%3Dfooter&data=05%7C01%7Carakeri%40microsoft.com%7Cf40bd0628c604c0f3ae408da494b2f42%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637902884543417737%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=G%2F6hqWpl9E6qoo33IS6kJhQls68x%2FhlzGlCFZrWXEzc%3D&reserved=0>. -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org<mailto:blink-dev+unsubscr...@chromium.org>. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/5efc25ed-0c43-4c7d-e877-d05b6a0512f3%40chromium.org<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fa%2Fchromium.org%2Fd%2Fmsgid%2Fblink-dev%2F5efc25ed-0c43-4c7d-e877-d05b6a0512f3%2540chromium.org%3Futm_medium%3Demail%26utm_source%3Dfooter&data=05%7C01%7Carakeri%40microsoft.com%7Cf40bd0628c604c0f3ae408da494b2f42%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637902884543417737%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=7%2FHUI0jkysy8b886NlLl1zsV8tbyenkn8c2X4FkUi8A%3D&reserved=0>. -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org<mailto:blink-dev+unsubscr...@chromium.org>. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/SJ0PR00MB1141ACDFA8EA11EAF30D96B3A6A29%40SJ0PR00MB1141.namprd00.prod.outlook.com<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fa%2Fchromium.org%2Fd%2Fmsgid%2Fblink-dev%2FSJ0PR00MB1141ACDFA8EA11EAF30D96B3A6A29%2540SJ0PR00MB1141.namprd00.prod.outlook.com%3Futm_medium%3Demail%26utm_source%3Dfooter&data=05%7C01%7Carakeri%40microsoft.com%7Cf40bd0628c604c0f3ae408da494b2f42%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637902884543417737%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=gRG9PqilwIS7be6%2B5zUVZXDufPpMnWsc1n%2BBk%2FJUhgA%3D&reserved=0>. -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org<mailto:blink-dev+unsubscr...@chromium.org>. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/1985d9a0-04e9-f1f3-75d4-c398b28455dd%40gmail.com<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fa%2Fchromium.org%2Fd%2Fmsgid%2Fblink-dev%2F1985d9a0-04e9-f1f3-75d4-c398b28455dd%2540gmail.com%3Futm_medium%3Demail%26utm_source%3Dfooter&data=05%7C01%7Carakeri%40microsoft.com%7Cf40bd0628c604c0f3ae408da494b2f42%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637902884543417737%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=xcGKQwVBB0ymNa83NwbEDci0wcB3%2FZhTrQGhWHIPZqY%3D&reserved=0>. -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/MW4PR00MB1148EE8B9CCDC5B79623E4F1A6A49%40MW4PR00MB1148.namprd00.prod.outlook.com.
