LGTM3. I don't think the issue of vertical-align shorthand isn't a blocker.
On Thu, Jan 12, 2023 at 2:20 AM Rick Byers <rby...@chromium.org> wrote: > On Wed, Jan 11, 2023 at 12:13 PM Ian Kilpatrick <ikilpatr...@google.com> > wrote: > >> >> >> On Wed, Jan 11, 2023 at 8:58 AM Rick Byers <rby...@chromium.org> wrote: >> >>> On Wed, Jan 11, 2023 at 11:14 AM Ian Kilpatrick <ikilpatr...@google.com> >>> wrote: >>> >>>> >>>> On Wed, Jan 11, 2023 at 7:28 AM Rick Byers <rby...@chromium.org> wrote: >>>> >>>>> Given the lack of signals from other implementers, any other >>>>> indication on the maturity of the spec? I searched for open bugs and found >>>>> only this one <https://github.com/w3c/csswg-drafts/issues/8214> which >>>>> sounds fairly minor to me - likely resolvable without major compat >>>>> implications. >>>>> >>>> >>>> We got a positive signal from the Firefox folks here: >>>> https://github.com/mozilla/standards-positions/issues/727 >>>> >>> >>> Yep, that's great. But what I was asking was that you're not aware of >>> any outstanding design debates or bugs which might cause future compat >>> issues, right? >>> >> >> Oh sorry - missed that part of your question. No not particularly - the >> open issue which we raised ( >> https://github.com/w3c/csswg-drafts/issues/8214) is surrounding a >> clarification to the spec for a somewhat edge case. We've implemented what >> we think is the best behaviour but wanted to double check with the broader >> group. We'll be able to change this specific behaviour safely after we ship >> if needed as it is a relative edge case. >> >> (The case in question is that the "inline-block" baseline algorithm >> contains a lot of quirks and counter intuitive behaviour, e.g. tables get >> skipped in some cases, and for things with "overflow: hidden" the baseline >> is ignored, the behavour we've implemented uses the baseline behaviour from >> flex/grid - see >> https://www.software.hixie.ch/utilities/js/live-dom-viewer/?saved=11177 for >> an explicit example). >> > > Makes sense, thanks, LGTM2. > > >>> Regardless, I agree this is quite minor, seems reasonable to ship absent >>>>> any known objections or significant outstanding issues. >>>>> >>>> >>>> Yeah this is a very minor feature all things considered. >>>> >>>> >>>>> >>>>> Thanks, >>>>> Rick >>>>> >>>>> On Tue, Jan 10, 2023 at 11:13 PM 一丝 <yio...@gmail.com> wrote: >>>>> >>>>>> We can use >>>>>> https://w3c.github.io/csswg-drafts/css-inline-3/#baseline-source >>>>>> >>>>>> 以上 >>>>>> 一丝 >>>>>> >>>>>> >>>>>> Ian Kilpatrick <ikilpatr...@chromium.org> 于2023年1月11日周三 08:19写道： >>>>>> >>>>>>> >>>>>>> >>>>>>> On Tue, Jan 10, 2023 at 4:48 AM Yoav Weiss <yoavwe...@chromium.org> >>>>>>> wrote: >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Mon, Jan 9, 2023 at 7:24 PM Ian Kilpatrick < >>>>>>>> ikilpatr...@chromium.org> wrote: >>>>>>>> >>>>>>>>> Contact emailsikilpatr...@chromium.org >>>>>>>>> >>>>>>>>> ExplainerNone >>>>>>>>> >>>>>>>>> Specification >>>>>>>>> https://drafts.csswg.org/css-inline-3/#baseline-source >>>>>>>>> >>>>>>>> >>>>>>>> link seems down :/ >>>>>>>> >>>>>>> >>>>>>> Yeah the csswg server is a little sporadic at the moment. Up at the >>>>>>> moment. >>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> Summary >>>>>>>>> >>>>>>>>> The "baseline-source" properties allows web developers to specify >>>>>>>>> if an inline-level box should use the "first" or "last" baseline for >>>>>>>>> alignment within an linebox. Today the default behaviour is confusing >>>>>>>>> for >>>>>>>>> web developers. Consider: test <div style="display: >>>>>>>>> inline-block;">line1<br>line2</div> test <div style="display: >>>>>>>>> inline-flex;">line1<br>line2</div> The "inline-block" will align to >>>>>>>>> the >>>>>>>>> last baseline, and the "inline-flex" will align to the first baseline. >>>>>>>>> "baseline-source: auto" is the existing (confusing) behaviour. Web >>>>>>>>> developers can specify "baseline-source: first" or "baseline-source: >>>>>>>>> last" >>>>>>>>> to directly determine how they want these boxes to align within a >>>>>>>>> line-box. >>>>>>>>> >>>>>>>>> >>>>>>>>> Blink componentBlink>Layout>Inline >>>>>>>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ELayout%3EInline> >>>>>>>>> >>>>>>>>> TAG reviewHappy to file one if desired. >>>>>>>>> >>>>>>>> Will we be the first to ship this? If so, I believe one is >>>>>>>> required. >>>>>>>> >>>>>>> >>>>>>> Done - It's a very small improvement to an existing API set so >>>>>>> unclear but filed one anyway. >>>>>>> https://github.com/w3ctag/design-reviews/issues/801 >>>>>>> >>>>>>> >>>>>>>>> TAG review statusNot applicable >>>>>>>>> >>>>>>>>> Risks >>>>>>>>> >>>>>>>>> >>>>>>>>> Interoperability and Compatibility >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> *Gecko*: No signal >>>>>>>>> https://bugzilla.mozilla.org/show_bug.cgi?id=1805273 >>>>>>>>> >>>>>>>>> *WebKit*: No signal https://bugs.webkit.org/show_bug.cgi?id=249094 >>>>>>>>> >>>>>>>> >>>>>>>> Can you file for https://bit.ly/blink-signals? >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> Done >>>>>>> https://github.com/mozilla/standards-positions/issues/727 >>>>>>> https://github.com/WebKit/standards-positions/issues/118 >>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> *Web developers*: Positive from my discussions. This has been a >>>>>>>>> consistent source of frustration with developers trying to align >>>>>>>>> content >>>>>>>>> within a line-box. >>>>>>>>> >>>>>>>> Any links? >>>>>>>> >>>>>>> >>>>>>> This is primarily discussions I've had with developers with >>>>>>> frustration with the current behaviour. No public links unfortunately. >>>>>>> >>>>>>> >>>>>>>>> *Other signals*: >>>>>>>>> >>>>>>>>> WebView application risks >>>>>>>>> >>>>>>>>> Does this intent deprecate or change behavior of existing APIs, >>>>>>>>> such that it has potentially high risk for Android WebView-based >>>>>>>>> applications? >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Debuggability >>>>>>>>> >>>>>>>>> Standard devtools CSS debugging. >>>>>>>>> >>>>>>>>> Will this feature be supported on all six Blink platforms >>>>>>>>> (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?Yes >>>>>>>>> >>>>>>>>> Is this feature fully tested by web-platform-tests >>>>>>>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>>>>>>> ?Yes >>>>>>>>> https://wpt.fyi/results/css/css-inline/baseline-source?label=master&label=experimental&aligned&view=subtest&q=baseline-source >>>>>>>>> >>>>>>>>> Flag name--experimental-web-platform-features >>>>>>>>> >>>>>>>>> Requires code in //chrome?False >>>>>>>>> >>>>>>>>> Tracking bug >>>>>>>>> https://bugs.chromium.org/p/chromium/issues/detail?id=1399711 >>>>>>>>> >>>>>>>>> Estimated milestones >>>>>>>>> >>>>>>>>> M111 >>>>>>>>> >>>>>>>>> >>>>>>>>> Anticipated spec changes >>>>>>>>> >>>>>>>>> https://github.com/w3c/csswg-drafts/issues/8214 still needs to be >>>>>>>>> resolved. We've implemented what we believe the "good" behaviour is. >>>>>>>>> The >>>>>>>>> CSSWG is a little backed up with issues at the moment, and may take a >>>>>>>>> while >>>>>>>>> to address. Trivial to switch behaviour. >>>>>>>>> >>>>>>>>> >>>>>>>>> Link to entry on the Chrome Platform Status >>>>>>>>> https://chromestatus.com/feature/5730575560736768 >>>>>>>>> >>>>>>>>> Links to previous Intent discussionsIntent to prototype: >>>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAJL3UpRe9mDOH4EV_-mo_-7NQL1cTZksivfs8X2oRHJ89YX82g%40mail.gmail.com >>>>>>>>> >>>>>>>>> >>>>>>>>> This intent message was generated by Chrome Platform Status >>>>>>>>> <https://chromestatus.com/>. >>>>>>>>> >>>>>>>>> -- >>>>>>>>> You received this message because you are subscribed to the Google >>>>>>>>> Groups "blink-dev" group. >>>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>>> send an email to blink-dev+unsubscr...@chromium.org. >>>>>>>>> To view this discussion on the web visit >>>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAJL3UpSXHyzpVHet2rBKdK31n8s-f4zq9QrhWWVNHZ6oSbTuFQ%40mail.gmail.com >>>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAJL3UpSXHyzpVHet2rBKdK31n8s-f4zq9QrhWWVNHZ6oSbTuFQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>>>>> . >>>>>>>>> >>>>>>>> -- >>>>>>>> You received this message because you are subscribed to the Google >>>>>>>> Groups "blink-dev" group. >>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>> send an email to blink-dev+unsubscr...@chromium.org. >>>>>>>> To view this discussion on the web visit >>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfVjgqw4cjNDEDHrsgYXafWNtUXcKuC-yNzrmbamor2xxg%40mail.gmail.com >>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfVjgqw4cjNDEDHrsgYXafWNtUXcKuC-yNzrmbamor2xxg%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>>>> . >>>>>>>> >>>>>>> -- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "blink-dev" group. >>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>> send an email to blink-dev+unsubscr...@chromium.org. >>>>>>> To view this discussion on the web visit >>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAJL3UpQiiLzkbyySG3KBGqP4L6qPto-pV3E%3D_bo9n7-bt2HQug%40mail.gmail.com >>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAJL3UpQiiLzkbyySG3KBGqP4L6qPto-pV3E%3D_bo9n7-bt2HQug%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>>> . >>>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "blink-dev" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to blink-dev+unsubscr...@chromium.org. >>>>>> To view this discussion on the web visit >>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CA%2B-d5ZoTwmT2xSuqAevHCp4T9ja6wjX8L6Vf8GkgcKtFF21NCQ%40mail.gmail.com >>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CA%2B-d5ZoTwmT2xSuqAevHCp4T9ja6wjX8L6Vf8GkgcKtFF21NCQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>> . >>>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "blink-dev" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to blink-dev+unsubscr...@chromium.org. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY_ov_41p1M%3DqW965FXnURKkW8ochTM3H0aFB-5OMXy7eg%40mail.gmail.com >>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY_ov_41p1M%3DqW965FXnURKkW8ochTM3H0aFB-5OMXy7eg%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY8oW-sn6LJ16MOR4JW3%3Dgnf2DKQ68KVrEJPDbCh_MGjNA%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY8oW-sn6LJ16MOR4JW3%3Dgnf2DKQ68KVrEJPDbCh_MGjNA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- TAMURA Kent Software Engineer, Google -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqEs%2Ba%3D4Kt7hZS6s4oj399Urnb-spxQSuwXacBoYttXA3w%40mail.gmail.com.
