Thanks Domenic for mentoring and vouching :) I took a very cursory look at the API shape and sent a small fix <https://github.com/WICG/document-picture-in-picture/pull/81>, thanks for reviewing that.
The concerns on https://github.com/WebKit/standards-positions/issues/41 are device independence and portability. For the Android support, can you say anything about future expectations? Is this feature simply not important on mobile and it might be a desktop-only API for the foreseeable future, or would Android support make sense for some use cases? If so, does it seem tractable given the requisite changes to Android APIs? On Tue, Jun 13, 2023 at 4:16 AM Domenic Denicola <[email protected]> wrote: > I was the spec mentor for Tommy's work on this feature, and am chiming in > to provide the requested spec maturity summary > <https://www.chromium.org/blink/launching-features/#:~:text=If%20your%20specification%20isn%27t%20a%20modification%20of%20an%20existing%20specification%2C%20include%20a%20one%2Dline%20spec%20maturity%20summary%20from%20someone%20outside%20your%20team%20(like%20your%20spec%20mentor)%20who%20has%20done%20a%20review.> > . > > I'm very happy with the spec work for this feature. Tommy worked hard to > incorporate all my feedback about how to ensure everything was rigorously > defined, and integrated well with existing concepts like opening new > windows (navigables). The monkey patches are small, focused, and easy to > understand. > > There is some TAG feedback that seems to wish this was part of > window.open() or some other more-general API, but I think that advice is > not correct, and the current API design is good, due to the > singleton-per-top-level-traversable nature of a document PiP window. In my > opinion this makes the window.documentPictureInPicture entrypoint, with its > requestWindow(), window, and onenter properties, a good API for the use > case. > > > On Tue, Jun 13, 2023 at 1:51 AM 'Tommy Steimel' via blink-dev < > [email protected]> wrote: > >> Contact [email protected], [email protected], >> [email protected] >> >> Explainer >> https://github.com/WICG/document-picture-in-picture/blob/main/README.md >> >> Specificationhttps://wicg.github.io/document-picture-in-picture >> >> Summary >> >> Document PiP adds a new API to open an always-on-top window that can be >> populated with arbitrary HTMLElements. This is an expansion upon the >> existing HTMLVideoElement API that only allows for an HTMLVideoElement to >> be put into a PiP window. This allows web developers to provide a better >> PiP experience to users. >> >> >> Blink componentBlink>Media>PictureInPicture >> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EMedia%3EPictureInPicture> >> >> TAG reviewhttps://github.com/w3ctag/design-reviews/issues/798 >> >> TAG review statusIssues open >> >> Risks >> >> >> Interoperability and Compatibility >> >> >> >> *Gecko*: No signal ( >> https://github.com/mozilla/standards-positions/issues/670) >> >> *WebKit*: No signal ( >> https://github.com/WebKit/standards-positions/issues/41) no official >> position, but have some concerns >> >> *Web developers*: Positive ( >> https://discourse.wicg.io/t/proposal-document-picture-in-picture/5736/2?u=steimel) >> In addition to the linked comment, we have some signals from partners that >> this would be valuable, and are checking to see if they are OK making that >> public >> >> *Other signals*: >> >> WebView application risks >> >> Does this intent deprecate or change behavior of existing APIs, such that >> it has potentially high risk for Android WebView-based applications? >> >> N/A since we are not enabling this API on Android >> >> >> Debuggability >> >> The new methods and properties proposed in this spec will show up in >> autocomplete functionality (e.g. window.documentPictureInPicture). The >> enter event will support event listener breakpoints in the >> "Picture-in-Picture" category. >> >> >> Will this feature be supported on all six Blink platforms (Windows, Mac, >> Linux, Chrome OS, Android, and Android WebView)?No >> >> At least initially, we're not supporting Android since the Android APIs >> don't easily support always-on-top windows with arbitrary interaction >> >> >> Is this feature fully tested by web-platform-tests >> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >> ?Yes >> >> Flag nameblink::features::kDocumentPictureInPictureAPI >> >> Requires code in //chrome?True >> >> Tracking bughttps://crbug.com/1315351 >> >> Launch bughttps://crbug.com/1269059 >> >> MeasurementWe have UseCounters for the documentPictureInPicture APIs >> >> Availability expectationFeature is available only in Chromium browsers >> for the foreseeable future >> >> Adoption expectationFeature is used by specific partner(s) to provide >> functionality within 12 months of launch in Chrome >> >> Adoption planFeature is already being used in the OT by partners who >> plan to continue using the feature in stable >> >> Non-OSS dependencies >> >> Does the feature depend on any code or APIs outside the Chromium open >> source repository and its open-source dependencies to function? >> N/A >> >> Estimated milestones >> Shipping on desktop 116 >> OriginTrial desktop last 115 >> OriginTrial desktop first 111 >> >> Anticipated spec changes >> >> Open questions about a feature may be a source of future web compat or >> interop issues. Please list open issues (e.g. links to known github issues >> in the project for the feature specification) whose resolution may >> introduce web compat/interop risk (e.g., changing to naming or structure of >> the API in a non-backward-compatible way). >> No future backwards-incompatible spec changes anticipated >> >> Link to entry on the Chrome Platform Status >> https://chromestatus.com/feature/5755179560337408 >> >> Links to previous Intent discussionsIntent to prototype: >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGyVZ8L-SmBFbBMvvbm0x3TwZ66JQ1Fm7_zb3nSiBvYhXavAuA%40mail.gmail.com >> Intent >> to Experiment: >> https://groups.google.com/a/chromium.org/g/blink-dev/c/Tz1gUh92dXs >> >> >> This intent message was generated by Chrome Platform Status >> <https://chromestatus.com/>. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAE-AwAr2EHEEbqD0X-7bt_4NGAxFhyRz_0wv2c6Bvi65iYw30Q%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAE-AwAr2EHEEbqD0X-7bt_4NGAxFhyRz_0wv2c6Bvi65iYw30Q%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM0wra9xZXrXi9f8upH7EZdaF2mOgn%3DVz5ZnDR%2B3xdEaHiG8LQ%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM0wra9xZXrXi9f8upH7EZdaF2mOgn%3DVz5ZnDR%2B3xdEaHiG8LQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYd_e%3DfSNRXGoBpXPE%2BH9F7BnQ_jMCrA-5pijCh%2BcjtGUQ%40mail.gmail.com.
