LGTM2 On Wed, Nov 15, 2023 at 7:52 AM Yoav Weiss <[email protected]> wrote:
> LGTM1 > > I agree that the compat risk here seems low, and the interop win more than > makes up for it. > > On Monday, November 13, 2023 at 4:04:02 PM UTC+1 Mustaq Ahmed wrote: > >> Hi Chris: >> >> The other 5 review categories are now green, the last one was marked a >> few hours ago. >> >> Please let me know if anything else is needed for the Blink approval >> process. We are targeting M121. >> >> Mustaq >> >> >> >> On Thu, Nov 2, 2023 at 12:07 PM Chris Harrelson <[email protected]> >> wrote: >> >>> It will be after you click the button to start an API owners review. >>> Also don't forget to start the other 5 review categories. >>> >>> On Thu, Nov 2, 2023 at 9:01 AM Mustaq Ahmed <[email protected]> wrote: >>> >>>> Hi Chris: >>>> >>>> https://chromestatus.com/feature/6266812908175360 is the new entry for >>>> this feature (because feature type is read-only). The review bits should >>>> now be visible to API Owners, please let know if that's not the case. >>>> >>>> Mustaq >>>> >>>> On Fri, Oct 27, 2023 at 5:03 PM Chris Harrelson <[email protected]> >>>> wrote: >>>> >>>>> Hi Mustaq, >>>>> >>>>> "web developer facing change to existing code" is meant for >>>>> "bugfix-level changes to web APIs", which is why it only requires a PSA >>>>> (sorry for the confusion - this has been a common issue and the >>>>> chromestatus team is working on improved UI to be less confusing). >>>>> >>>>> In your case you are making a change that adjusts web-exposed behavior >>>>> enough that it requires an I2S. So you'll need to update the feature type >>>>> and file for all 5 review bits before the API owners can re-review. >>>>> >>>>> On Tue, Oct 24, 2023 at 9:30 AM Mustaq Ahmed <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi Mike: >>>>>> >>>>>> Through our offline discussion I learned that for "web developer >>>>>> facing change to existing code", the new intent process requires >>>>>> merely a "PSA" without (perhaps) any need for additional approvals. I >>>>>> changed the email template subject here from "PSA" to "I2S" only to >>>>>> secure >>>>>> "API Owners" approval, finding no obvious way to do it through the >>>>>> chromestatus UI! >>>>>> >>>>>> Anyway, the updated chromestatus entry now seems to say those >>>>>> additional approvals are not needed. Please let me know if I missed >>>>>> anything. >>>>>> >>>>>> Mustaq >>>>>> >>>>>> >>>>>> >>>>>> On Mon, Oct 23, 2023 at 10:39 AM Mike Taylor <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> Hi Mustaq, >>>>>>> >>>>>>> Please take a moment to request the other review bits (API OWNERs >>>>>>> will wait until those are in progress to begin our review). See >>>>>>> https://groups.google.com/a/chromium.org/g/blink-dev/c/bqvB1oap0Yc/m/YlO8DEHgAQAJ >>>>>>> for more info. >>>>>>> >>>>>>> thanks! >>>>>>> Mike >>>>>>> On 10/19/23 3:41 PM, Mustaq Ahmed wrote: >>>>>>> >>>>>>> Contact emails [email protected], [email protected] >>>>>>> >>>>>>> Specification >>>>>>> https://www.w3.org/TR/uievents/#events-mouseevent-event-order >>>>>>> >>>>>>> Summary >>>>>>> >>>>>>> After an event target gets removed from the DOM, the logical target >>>>>>> of the pointer as implied by the Pointer and Mouse boundary events (i.e. >>>>>>> over, out, enter and leave events) should be the nearest ancestor still >>>>>>> attached to the DOM. PEWG has recently reached consensus on this >>>>>>> behavior, >>>>>>> see https://github.com/web-platform-tests/interop/issues/380. >>>>>>> Chrome has been keeping track of a node even after it gets removed from >>>>>>> DOM. As a result, if the pointer moves to a new node B after the >>>>>>> hit-test >>>>>>> node A is removed from DOM, the boundary event sequence (pointerover, >>>>>>> pointerout, pointerenter, pointerleave events and the corresponding >>>>>>> mouse >>>>>>> events) used to imply a pointer movement from A to B. As per the new >>>>>>> consensus, the event sequence should imply a pointer movement from the >>>>>>> "parent of A" to B. >>>>>>> >>>>>>> >>>>>>> Blink component Blink>Input >>>>>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EInput> >>>>>>> >>>>>>> TAG review None >>>>>>> >>>>>>> TAG review status Not applicable >>>>>>> >>>>>>> Risks >>>>>>> >>>>>>> >>>>>>> Interoperability and Compatibility >>>>>>> >>>>>>> There is no interop risk because major browsers are currently all >>>>>>> slightly different from one another. We are strictly improving the >>>>>>> situation through the intent here by having Chrome match an agreed-upon >>>>>>> behavior that's already tested ( >>>>>>> https://github.com/web-platform-tests/interop/issues/380). The >>>>>>> compat risk is negligible for the same reason, existing sites could not >>>>>>> rely on the current behavior in all browsers. This is also changing a >>>>>>> very >>>>>>> narrow use-case. >>>>>>> >>>>>>> >>>>>>> *Gecko*: Positive ( >>>>>>> https://github.com/web-platform-tests/interop/issues/380) Mozilla >>>>>>> originally called out the interop problem here. >>>>>>> >>>>>>> *WebKit*: No signal >>>>>>> >>>>>>> *Web developers*: Positive (https://crbug.com/1147998) >>>>>>> >>>>>>> *Other signals*: >>>>>>> >>>>>>> WebView application risks >>>>>>> >>>>>>> Does this intent deprecate or change behavior of existing APIs, such >>>>>>> that it has potentially high risk for Android WebView-based >>>>>>> applications? >>>>>>> >>>>>>> None >>>>>>> >>>>>>> >>>>>>> Debuggability >>>>>>> >>>>>>> None >>>>>>> >>>>>>> >>>>>>> Will this feature be supported on all six Blink platforms (Windows, >>>>>>> Mac, Linux, Chrome OS, Android, and Android WebView)? Yes >>>>>>> >>>>>>> Is this feature fully tested by web-platform-tests >>>>>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>>>>> ? Yes >>>>>>> >>>>>>> >>>>>>> https://wpt.fyi/results/pointerevents?label=master&label=experimental&aligned&q=pointerevent_after_target_appended.html%20or%20pointerevent_after_target_removed.html%20or%20pointerup_after_pointerdown_target_removed.html >>>>>>> >>>>>>> >>>>>>> Flag name on chrome://flags None >>>>>>> >>>>>>> Finch feature name BoundaryEventDispatchTracksNodeRemoval >>>>>>> >>>>>>> Requires code in //chrome? False >>>>>>> >>>>>>> Tracking bug https://crbug.com/1147998 >>>>>>> >>>>>>> Sample links >>>>>>> https://output.jsbin.com/yumacid >>>>>>> >>>>>>> Estimated milestones >>>>>>> Shipping on desktop 121 >>>>>>> Shipping on Android 121 >>>>>>> Shipping on WebView 121 >>>>>>> >>>>>>> Anticipated spec changes >>>>>>> >>>>>>> Open questions about a feature may be a source of future web compat >>>>>>> or interop issues. Please list open issues (e.g. links to known github >>>>>>> issues in the project for the feature specification) whose resolution >>>>>>> may >>>>>>> introduce web compat/interop risk (e.g., changing to naming or >>>>>>> structure of >>>>>>> the API in a non-backward-compatible way). >>>>>>> None >>>>>>> >>>>>>> Link to entry on the Chrome Platform Status >>>>>>> https://chromestatus.com/feature/5182447084109824 >>>>>>> >>>>>>> This intent message was generated by Chrome Platform Status >>>>>>> <https://chromestatus.com/>. >>>>>>> -- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "blink-dev" group. >>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>> send an email to [email protected]. >>>>>>> To view this discussion on the web visit >>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAB0cuO5zUdYJkRxo5kdVWpFJ%3DB50okhHr0EuWuc-WX9g7BPW0A%40mail.gmail.com >>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAB0cuO5zUdYJkRxo5kdVWpFJ%3DB50okhHr0EuWuc-WX9g7BPW0A%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>>> . >>>>>>> >>>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "blink-dev" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to [email protected]. >>>>>> To view this discussion on the web visit >>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAB0cuO67thtshr2w-dD%3Dy%2B-KoT_r0iKihadFhh-nxZkJDbBWGQ%40mail.gmail.com >>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAB0cuO67thtshr2w-dD%3Dy%2B-KoT_r0iKihadFhh-nxZkJDbBWGQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>> . >>>>>> >>>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAB0cuO6UpuKK%2BJmmdzuh1bu2gU4Cja75Ww4OVXJyuEv306KUmQ%40mail.gmail.com >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAB0cuO6UpuKK%2BJmmdzuh1bu2gU4Cja75Ww4OVXJyuEv306KUmQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/448024af-5185-44b3-831a-051a3e4bb95fn%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/448024af-5185-44b3-831a-051a3e4bb95fn%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9dMAn11%2B0yBaxqoH4Vu82rSo8DyaAwx4w5Q%3DTooy8nAQ%40mail.gmail.com.
