On Fri, Jan 19, 2024 at 7:54 PM Mason Freed <mas...@chromium.org> wrote:
> > > On Friday, January 19, 2024 at 12:27:50 PM UTC-8 vmp...@google.com wrote: > > Interoperability and Compatibility > > The use counter for getInnerHTML() (https://chromestatus.com/ > metrics/feature/timeline/popularity/3874) shows 0.04% of page loads using > this function as of January 2024. That represents high usage for > deprecation, however, the numbers were quite similar for the deprecation of > the old `shadowroot` attribute, and the removal of that feature generated > zero bug reports. It is my strong belief that since this feature is only > shipped in Chrome, the vast majority of usage is guarded by feature checks. > So this deprecation should be safer than it would seem from the numbers. My > plan is to very slowly disable the API and monitor closely for bug reports. > That approach was quite successful for the removal of shadowroot. If bugs > are reported, I'll back off and make a new plan. > > > I agree that I expect most uses to be feature checked. That being said, > have you tried to figure out where the 0.04% is coming from? Is it a lot of > small uses or a few big sites that keep using it? If it's the latter, it > may be worth it to reach out. > > > That's a good point. So I just took a look a the top 8 users from the use > counter page > <https://chromestatus.com/metrics/feature/timeline/popularity/3874>. Of > those, 2 do not contain any usage of getInnerHTML(). All 6 of the remainder > come from one single library, "Auryc JavaScript Client-Side Library". And > that library a) already feature checks for declarative shadow DOM before > using getInnerHTML(), and further b) feature checks the *old* `shadowroot` > attribute. So I suspect the use counter is already overcounting the usage > - see this bug for why > <https://github.com/GoogleChrome/chromium-dashboard/issues/1545>. > > Thanks for pushing on this - let me know if the above convinces you that > the risk should be low. > Yeah, I think the risk is low here. FWIW, I couldn't find any relevant github or contact info for this library but if you had better luck finding contact information, we might as well file an issue or send an email. > Thanks, > Mason > > > > > *Gecko*: No signal > > *WebKit*: No signal > > *Web developers*: No signals > > *Other signals*: > > WebView application risks > > Does this intent deprecate or change behavior of existing APIs, such that > it has potentially high risk for Android WebView-based applications? > > None > > > Debuggability > > None > > > Is this feature fully tested by web-platform-tests > <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> > ?No > > Flag name on chrome://flagsNone > > Finch feature nameNone > > Non-finch justificationNone > > Requires code in //chrome?False > > Tracking bughttps://crbug.com/1519972 > > Estimated milestones > > No milestones specified > > > Link to entry on the Chrome Platform Statushttps://chromestatus.com/ > feature/5081733588582400 > > This intent message was generated by me, manually, because of this bug > <https://github.com/GoogleChrome/chromium-dashboard/issues/3596>. > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit https://groups.google.com/a/ > chromium.org/d/msgid/blink-dev/CAM%3DNeDhpHobDUy1VwZ2rmy5DBUVfsm8 > ijXOEtk%2B1eHjJgu6FRg%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM%3DNeDhpHobDUy1VwZ2rmy5DBUVfsm8ijXOEtk%2B1eHjJgu6FRg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2PfrHxBnr_u6Cc1T7-TtVnQM7RUNKV47zcsvRr7-jUuGg%40mail.gmail.com.
