LGTM2 On Wed, Jan 31, 2024 at 8:00 AM Yoav Weiss (@Shopify) < [email protected]> wrote:
> LGTM1 > > On Friday, January 26, 2024 at 10:27:50 AM UTC+1 Noam Rosenthal wrote: > > Contact [email protected], [email protected] > > Explainerhttps://github.com/WICG/view-transitions/blob/main/ > navigation-activation-explainer.md > > Specificationhttps://html.spec.whatwg.org/multipage/nav-history-apis. > html#navigation-activation-interface > > Summary > > navigation.activation stores state about when the current Document was > activated (e.g., when it was initialized, or restored from the back/forward > cache). > > > I was confused by "when" here (as we already shipped activationStart > <https://wicg.github.io/nav-speculation/prerendering.html#ref-for-dom-performancenavigationtiming-activationstart>). > The explainer does a good job of explaining this though. > > > > Blink componentBlink>History > <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EHistory> > > TAG reviewhttps://github.com/w3ctag/design-reviews/issues/921 > > TAG review statusIssues addressed > > Risks > > > Interoperability and Compatibility > > None > > > *Gecko*: Positive (https://github.com/mozilla/ > standards-positions/issues/928) > > *WebKit*: No signal (https://github.com/WebKit/ > standards-positions/issues/282) > > *Web developers*: Positive > > *Other signals*: > > Security > > This is a cross-document (navigation) feature, so designing it we needed > to take care of cross-origin navigation related risks. Since > `navigation.activation` is part of the navigation API, it uses the same > semantics and protections. We only expose things that are otherwise exposed > by the navigation API or in other means. > > > WebView application risks > > Does this intent deprecate or change behavior of existing APIs, such that > it has potentially high risk for Android WebView-based applications? > > None > > > Debuggability > > None > > > Will this feature be supported on all six Blink platforms (Windows, Mac, > Linux, ChromeOS, Android, and Android WebView)?Yes > > Is this feature fully tested by web-platform-tests > <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> > ?Yes > > https://wpt.fyi/results/navigation-api/navigation- > activation?label=master&label=experimental&aligned&q= > navigation%20activation > > > Flag name on chrome://flagsNavigationActivation > > Finch feature nameNone > > Non-finch justification > > It's a web-API, exposing it gradually doesn't make sense. > > > Requires code in //chrome?False > > Estimated milestonesShipping on desktop123Shipping on Android123Shipping > on WebView123Shipping on WebView123 > > Anticipated spec changes > > Open questions about a feature may be a source of future web compat or > interop issues. Please list open issues (e.g. links to known github issues > in the project for the feature specification) whose resolution may > introduce web compat/interop risk (e.g., changing to naming or structure of > the API in a non-backward-compatible way). > None > > Link to entry on the Chrome Platform Statushttps://chromestatus.com/ > feature/5076557983121408 > > Links to previous Intent discussionsIntent to prototype: https://groups. > google.com/a/chromium.org/d/msgid/blink-dev/CACf%3D2LJa-_ > 9cEjMU3Ds660KmW0u_G_M9S1Ah-14gAfk9Qhrp2g%40mail.gmail.com > > This intent message was generated by Chrome Platform Status > <https://chromestatus.com/>. > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/bda4f055-7c7a-4684-b8f3-42ee1cdd786cn%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/bda4f055-7c7a-4684-b8f3-42ee1cdd786cn%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw8t7sXaQ%3DcGuQFV0bkHJZqYq4ewRNywdZcEWA_ECph0Qg%40mail.gmail.com.
