> Is there any reason this isn't behind a flag? Apologies Mike, I've edited the feature status to reflect that it is indeed behind a flag right now. It's in the Experimental Web Platform Features group and has been since M131.
> I don't see that the spec says anything about querySelector, but its > evaluation depends on slot assignments. Should dirty slot assignments be > updated before running querySelector? Thanks Rune, I think you're right, we should definitely fix this so it is not observable. > Could you add the test links to the chromestatus entry? Thanks for calling this out, done! > Looking at wpt.fyi all tests are tentative, so they need to be made > non-tentative with proper spec references if they match the spec. Thanks for mentioning this, I've got a PR for this: https://github.com/web-platform-tests/wpt/pull/50056 > The spec does not match flattened nodes, but there are tests that are named > "flattened" which is confusing. For instance, IIUC, > https://wpt.live/css/css-scoping/has-slotted-flattened-001.tentative.html > should match the selector because a slot is assigned to another slot, not > because nodes are flattened through. I'm bringing a question on this to the CSSWG this week to ensure the spec references that the lookup should use the flat tree, and the tests and logic is updated accordingly. > 134? Updated to 134. On Thu, 9 Jan 2025, at 4:10 PM, Rune Lillesveen wrote: > On Thu, Jan 9, 2025 at 10:37 AM Chromestatus > <ad...@cr-status.appspotmail.com> wrote: >> Contact emails >> >> chrom...@keithcirkel.co.uk, keitha...@github.com >> >> Explainer >> >> https://drafts.csswg.org/css-scoping/#the-has-slotted-pseudo >> >> Specification >> >> https://drafts.csswg.org/css-scoping/#the-has-slotted-pseudo >> >> Summary >> >> The :has-slotted pseudo class represents a slot element with slotted >> content, such as a text node or element. This can be used to style elements >> based on whether or not they are using slot fallback content. >> > I don't see that the spec says anything about querySelector, but its > evaluation depends on slot assignments. Should dirty slot assignments be > updated before running querySelector? > > I see the implementation does not currently update the assignments. Since our > implementation updates slot assignments lazily as needed, what querySelector > matches will depend on which other APIs were invoked since the last rendering > update. > >> Is this feature fully tested by web-platform-tests >> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>? >> >> Yes > > Could you add the test links to the chromestatus entry? > > Looking at wpt.fyi all tests are tentative, so they need to be made > non-tentative with proper spec references if they match the spec. > > The spec does not match flattened nodes, but there are tests that are named > "flattened" which is confusing. For instance, IIUC, > https://wpt.live/css/css-scoping/has-slotted-flattened-001.tentative.html > should match the selector because a slot is assigned to another slot, not > because nodes are flattened through. >> >> >> Estimated milestones >> >> Shipping on desktop >> 133 >> Shipping on Android >> 133 >> Shipping on WebView >> 133 >> Shipping on iOS >> 133 > > 134? > > -- > Rune Lillesveen > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/3e6aca14-f4ff-4e82-a857-eee1b48aa808%40app.fastmail.com.
