Not yet, I'll land a few patches this week that will tidy up the points Rune
raised.
On Wed, 22 Jan 2025, at 4:02 PM, Chris Harrelson wrote:
> Hi Keith, is this intent ready for re-review?
>
> On Tue, Jan 14, 2025 at 5:40 AM Rune Lillesveen <futh...@chromium.org> wrote:
>> On Mon, Jan 13, 2025 at 7:38 PM Keith Cirkel <chrom...@keithcirkel.co.uk>
>> wrote:
>>> __
>>> > I don't see that the spec says anything about querySelector, but its
>>> > evaluation depends on slot assignments. Should dirty slot assignments be
>>> > updated before running querySelector?
>>>
>>> Thanks Rune, I think you're right, we should definitely fix this so it is
>>> not observable.
>>
>> FWIW, the slot assignments are made up-to-date for querySelector with :dir()
>> and auto directionality (tested with Chrome and Firefox), but I cannot find
>> anything in the spec calling this out specifically:
>>
>> <!DOCTYPE html>
>> <div id="host">
>> <template shadowrootmode="open">
>> <style>
>> slot:dir(rtl) { background-color: green; }
>> </style>
>> <slot dir="auto"></slot>
>> </template>
>> <div id="auto_div" slot="no">‏</div>
>> </div>
>> <script>
>> const root = host.shadowRoot;
>> const slot = root.querySelector("slot");
>> console.log(root.querySelector("slot:dir(rtl)"));
>> console.log(getComputedStyle(slot).backgroundColor);
>> auto_div.removeAttribute("slot");
>> console.log(root.querySelector("slot:dir(rtl)"));
>>
>> console.log(getComputedStyle(host.shadowRoot.querySelector("slot")).backgroundColor);
>> </script>
>>
>>>
>>> > Looking at wpt.fyi all tests are tentative, so they need to be made
>>> > non-tentative with proper spec references if they match the spec.
>>>
>>> Thanks for mentioning this, I've got a PR for this:
>>> https://github.com/web-platform-tests/wpt/pull/50056
>>
>> Remember to also update the rel=help links to actual spec references.
>>
>> --
>> Rune Lillesveen
>>
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "blink-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to blink-dev+unsubscr...@chromium.org.
>> To view this discussion visit
>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACuPfeS1QunKZk%2Bv_Vxix9eFO-qe_xkMOMzt_jHZA20x0LFPMA%40mail.gmail.com
>>
>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACuPfeS1QunKZk%2Bv_Vxix9eFO-qe_xkMOMzt_jHZA20x0LFPMA%40mail.gmail.com?utm_medium=email&utm_source=footer>.
--
You received this message because you are subscribed to the Google Groups
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-dev+unsubscr...@chromium.org.
To view this discussion visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/9a3e4dce-6f85-4d94-9ccc-140bf8b79e9a%40app.fastmail.com.
