LGTM3

On Wed, Feb 12, 2025 at 11:04 AM Yoav Weiss (@Shopify) <
yoavwe...@chromium.org> wrote:

> LGTM2
>
> On Wednesday, February 12, 2025 at 2:59:43 AM UTC+1 Domenic Denicola wrote:
>
>> LGTM1. I'm still curious on the web developer signals, if you have
>> anything to share there :)
>>
>> >> *Web developers*: No signals
>> >
>> > I'm just curious, have any web developers complained about this, or is
>> this mostly done out of a desire for interop, or...?
>>
>> On Tue, Feb 11, 2025 at 1:38 AM Chris Harrelson <chris...@chromium.org>
>> wrote:
>>
>>> On Tue, Feb 4, 2025 at 6:33 PM Domenic Denicola <dome...@chromium.org>
>>> wrote:
>>>
>>>> Is this feature fully tested by web-platform-tests
>>>>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>
>>>>>> ? No
>>>>>
>>>>>
>>>> This seems to be testable by checking the relative ordering of
>>>> setTimeout(f,0) and setInterval(g,0), with a test like
>>>> https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=13477 .
>>>> Maybe you could add one?
>>>>
>>>
>>> Good point. I added a test here
>>> <https://wpt.fyi/results/html/webappapis/timers/setinterval-settimeout-clamping.html?label=experimental&label=master&aligned>.
>>> I noted it in the chromestatus entry as well.
>>>
>>>>  justification None
>>>>>
>>>>>
>>>> A Finch flag seems important for this, just in case it causes compat
>>>> issues.
>>>>
>>>
>>> There is a finch flag (SetIntervalWithoutClamp), my mistake. Edited
>>> chromestatus.
>>>
>>>
>>> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/2842e492-ead5-49ab-b02a-62a7c85dd46bn%40chromium.org
> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/2842e492-ead5-49ab-b02a-62a7c85dd46bn%40chromium.org?utm_medium=email&utm_source=footer>
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY-UKBRTWpV_a5H1nTm94CoDV5KskD%2Bu1rh1A%2BRNb6Ue0w%40mail.gmail.com.

Reply via email to