LGTM2

On Wed, Sep 9, 2026 at 5:15 PM Rick Byers <[email protected]> wrote:

> Thanks Hubert, LGTM1 for the whole intent.
>
> On Wed, Sep 9, 2026 at 10:43 AM Hubert Chao <[email protected]> wrote:
>
>> On Tue, Sep 8, 2026 at 5:21 PM Rick Byers <[email protected]> wrote:
>>
>>> Thanks for the update!
>>> Hubert, can you comment on how your impl aligns with this spec change? I
>>> see the alg strings like MLKEM768-P256 in the spec, so I assume that's
>>> matching what you'retalking about here. So LGTM1 from me to ship that alg.
>>>
>>
>>  MLKEM768-X25519 which is part of this I2S is in PR that just got merged
>> in. There is no support for MLKEM768-P256 or MLKEM1024-P384 that is
>> implemented.
>>
>>
>>> But what about the others you've mentioned which don't seem mentioned in
>>> the spec (eg. ChaCha20-Poly1305)? I don't think we need to block on any
>>> industry-wide agreement on which exact protocols should be supported, but I
>>> do think we need a spec somewhere describing EXACTLY what we support (eg.
>>> for any browser which aims to be compatible with Chromium).
>>>
>>
>> All of the other algorithms being added are already in
>> https://wicg.github.io/webcrypto-modern-algos/. Links:
>>
>> ChaCha20-Poly1305:
>> https://wicg.github.io/webcrypto-modern-algos/#chacha20-poly1305
>> ML-DSA: https://wicg.github.io/webcrypto-modern-algos/#ml-dsa
>> ML-KEM: https://wicg.github.io/webcrypto-modern-algos/#ml-kem (only
>> supporting ML-KEM-768 and ML-KEM-1024)
>>
>> /hubert
>>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> To view this discussion visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY9-tEGMT1sWn1RtZ5YDPTL7o%2BB6-B-8gRsgQwQMaQR3WQ%40mail.gmail.com
> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY9-tEGMT1sWn1RtZ5YDPTL7o%2BB6-B-8gRsgQwQMaQR3WQ%40mail.gmail.com?utm_medium=email&utm_source=footer>
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYei2FO8vqEhmunGhW84P0pRTtwZRiRN%3DDmrniFcFpsGhQ%40mail.gmail.com.

Reply via email to