On 19 December 2012 20:59, Matevz Bradac <[email protected]> wrote: > Hi, > > I started implementing the responsive layout functionality, for which Joe > had > created a mockup in #240. There are a couple of issues to be resolved, any > suggestions are appreciated: > > 1. In the ticket there's a proposal for being able to turn this feature > on/off, > as it will impose significant changes on the layout, so some things may > not work > as expected right from the start. I've currently implemented this by > having two > types of templates (responsive- and old-style), and BloodhoundTheme's > __init__ > then checks for a specific trac.ini setting and switches to whatever is > set. >
This two versions of ticket page situation should be extremely short lived (one or up to max 2 release cycles). Maybe we could implement other changes on the new ticket page alone then as the old pages should be obsolete in a few weeks. > The problem I see here is that template content changes will have to be > synced > back and forth between both template types, i.e. any functional changes > done to > one template will have to be implemented in the other as well. I suppose > that > this is something we'd like to avoid, perhaps someone has a better > solution proposal? > > 2. Handling of widget macros: when using widget macros, each widget is a > more or > less self-contained entity. Due to that certain layouts may be difficult to > implement without changing other functionality. For example in the mockup > ticket > view in #240, the ticket header and the activity header are both placed in > the > same sticky div. But due to the activity feed being inserted as a > Timeline widget, > the separation of its header and data is not possible (without hacks). > (Or perhaps > I've interpreted the widget code incorrectly?) > > Cheers, > matevz >
