Excellent. I completely agree with just committing.

I guess that it is easy to forget that it is far easier to review someone's work by just doing an svn up rather than by downloading and attempting to apply a patch. Let's just get into the habit of committing and if it is considered worthy of comment then you can reply to the commit email or the ticket update email.

Thanks!
    Gary

On 04/02/13 16:03, Matevž Bradač wrote:
You're right of course, so I committed the changes in r1442158.

--
matevz

On 4. Feb, 2013, at 16:34, Branko Čibej wrote:

Can I please ask everyone, for the last time, to stop attaching patches
to issues and just commit them. :) Commit-Then-Review, not
discuss-to-death-in-the-issue-tracker-then-wait-for-someone-to-remember-to-commit.

You'll never get anywhere this way.

-- Brane


On 04.02.2013 16:30, Matevž Bradač wrote:
Hi,

I attached a new patch to the ticket, synced with the latest trunk changes ...

--
Branko Čibej
Director of Subversion | WANdisco | www.wandisco.com


Reply via email to