[
https://issues.apache.org/jira/browse/BLUR-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573131#comment-13573131
]
Aaron McCurry commented on BLUR-49:
-----------------------------------
Overall the patch looks really good. I do have a couple of issues.
1. There seems to be a few fields that are marked as required in the
Blur.thrift file but I didn't see the changes in that file, because when I
regenerate the code the generated code changes slightly.
2. I think the ClassDefinition constructor needs to be removed and the code in
the constructor placed into the convert method. Perhaps create a method that
creates the analyzerClassObject that if the ClassDefinition.initFunction is
non-null it calls the javascript code. If the ClassDefinition.className is
non-null then is just calls the normal code that is already there. If both are
populated, WARN in the log that the className is ignored and call the
initFunction code. That way once the creation of the BlurAnalyzer is complete
it's ready for use across all fields.
What do you think?
Aaron
> BlurAnalyzer add constructor arguments
> --------------------------------------
>
> Key: BLUR-49
> URL: https://issues.apache.org/jira/browse/BLUR-49
> Project: Apache Blur
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: Aaron McCurry
> Fix For: 0.2.0
>
> Attachments:
> 0001-BLUR-ID-49-Blur-Analyzer-Added-constructor-arguments.patch
>
>
> In the 0.2-dev branch, the BlurAnalyzer should be enhanced to allow
> constructor arguments to be passed in the ClassDefinition.arguments map. Not
> sure what the best way to implement this, but the use case would be creating
> a StandardAnalyzer with a non-default set of stop words.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
