[ 
https://issues.apache.org/jira/browse/BLUR-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667132#comment-13667132
 ] 

Aaron McCurry commented on BLUR-95:
-----------------------------------

Yeah the directory.copy should just be replaced with a filesystem.rename of the 
path of the directory that is trying to be imported.  However you need to 
handle the IOException from the applydeletes and close the reader, and rollback 
the writer as well as renaming the directory path to the .bad_index.  Let me 
know if you need anymore help, and yes I agree that we need a test for this 
class.

Thanks!

Aaron
                
> IndexImporter class - add a double check on the rowid to validate the index.
> ----------------------------------------------------------------------------
>
>                 Key: BLUR-95
>                 URL: https://issues.apache.org/jira/browse/BLUR-95
>             Project: Apache Blur
>          Issue Type: Improvement
>    Affects Versions: 0.1.5
>            Reporter: Aaron McCurry
>             Fix For: 0.1.5
>
>         Attachments: 0001-BLUR-ID-95-double-check-on-the-rowid.patch, 
> 0001-BLUR-ID-95-Double-check-on-the-rowid.patch
>
>
> In the IndexImporter add a double check to the importer that validates the 
> rowids in the import are valid ids for the given shard.  This can be done 
> when the rowids in the new index are iterated over during the delete phase.  
> A BlurPartitioner class can valid the rowid should be in the given shard.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to