[
https://issues.apache.org/jira/browse/BLUR-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667147#comment-13667147
]
Gagan Deep Juneja commented on BLUR-95:
---------------------------------------
Thanks for your reply!
I have following points to discuss.
1. We can handle IOException thrown from applyDeletes method. So here we need
two types of treatment like one when IOException thrown and another would be if
we found rowId in wrong shard. Here we need to do same work in both scenarios
the only difference is log messages that we need to show. By any chance can we
club these two scenarios? May be I am asking too much but I dont want to create
mess in the run method by writing duplicate code.
2. reader.close() is already taken care in finally clause of applyDeletes
method so I guess that would serve our purpose.
2. Can you please guide how to simulate this issue where rowId can be found in
wrong shard or should we create the scenario using mocking.
Regards,
Gagan
> IndexImporter class - add a double check on the rowid to validate the index.
> ----------------------------------------------------------------------------
>
> Key: BLUR-95
> URL: https://issues.apache.org/jira/browse/BLUR-95
> Project: Apache Blur
> Issue Type: Improvement
> Affects Versions: 0.1.5
> Reporter: Aaron McCurry
> Fix For: 0.1.5
>
> Attachments: 0001-BLUR-ID-95-double-check-on-the-rowid.patch,
> 0001-BLUR-ID-95-Double-check-on-the-rowid.patch
>
>
> In the IndexImporter add a double check to the importer that validates the
> rowids in the import are valid ids for the given shard. This can be done
> when the rowids in the new index are iterated over during the delete phase.
> A BlurPartitioner class can valid the rowid should be in the given shard.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
