[
https://issues.apache.org/jira/browse/BLUR-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13745989#comment-13745989
]
Aaron McCurry commented on BLUR-132:
------------------------------------
The patch looks great! However I have 2 small comments.
- In the "snapshotsDirectoryExists()" method, I think that you should reuse
the new method "getFileSystem"
- In the "getFileSystem" you should use "Configuration configuration =
_shardContext.getTableContext().getConfiguration();" instead of creating a new
Configuration object since it's such a heavy weight object.
If you want to make those 2 small changes and resubmit, or I can make those
changes and commit it now. I leave it up to you.
Thanks!
Aaron
> Create Index Snapshots
> ----------------------
>
> Key: BLUR-132
> URL: https://issues.apache.org/jira/browse/BLUR-132
> Project: Apache Blur
> Issue Type: New Feature
> Affects Versions: 0.3.0
> Reporter: Aaron McCurry
> Fix For: 0.3.0
>
> Attachments: Blur-132-part1.patch, blur-132-part2.patch,
> blur-132-part2-unit-tests.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
