[ 
https://issues.apache.org/jira/browse/BLUR-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13807566#comment-13807566
 ] 

Aaron McCurry commented on BLUR-289:
------------------------------------

Everything looks good in the patch.  I think though that the protocol 
(TBinaryProtocol) in the serializeTableDescriptor method should be the 
TJSONProtocol.  That way if someone wanted to take a look at the descriptor 
they could see the values without having to write code.  Other than that the 
rest looks good.

Thanks!

Aaron

> Table Properties are not being persisted to zookeeper
> -----------------------------------------------------
>
>                 Key: BLUR-289
>                 URL: https://issues.apache.org/jira/browse/BLUR-289
>             Project: Apache Blur
>          Issue Type: Bug
>          Components: Blur
>    Affects Versions: 0.3.0, 0.2.1
>            Reporter: Rahul Challapalli
>            Priority: Blocker
>             Fix For: 0.2.1
>
>         Attachments: blur-289.patch, persist_tableproperties.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to