2012/7/18 Rom Walton <[email protected]>:
> Howdy Folks,
>
> We have fixed most/all the issues that have been raised regarding the
> Git repos on the BOINC server.  You can find information about the Git
> repos here:
> http://boinc.berkeley.edu/git/
>
> Instructions for cloning the Git repos can be found here:
> http://boinc.berkeley.edu/trac/wiki/SourceCodeGit
>
> Instructions for installing Git on Windows can be found here:
> http://boinc.berkeley.edu/trac/wiki/SourceCodeGit/Windows
>
> Oliver did a great job of summarizing the repo changes:
> I kept boinc.git and boinccleaned.git at the same revision to facilitate
> testing/scrutinizing. The cleaning included:
>
> - svn author mapping (best effort)
> - partial commit message cleaning (SVN UUID removal)
> - removal of curl/icu/openssl/zlib binaries from history
>
> Testers want to focus on these things, in particular the last, most
> invasive step.
>
> As a general reminder about the migration so far:
>
> - independent SVN projects got separated into dedicated repos
> - branches and tags have been cleansed (obsolete stuff removed)
>
> Thanks in advance.

Okay, here goes my list:

* Not much change in the openness and transparency of the migration.
Was the conversion Oliver's one-man job? If tracking down names for
the SVN author-mapping was so hard, why did nobody ask for help in the
lists? Where are the conversion and cleanup scripts, so that people
can contribute? What tool was used for the conversion? (does it really
take weeks to run??)

* In both boinc.git and boinccleaned.git, all the history before
r12316 is duplicated. In some places even 3x or 4x. Some of these
duplicated chains of commits contain the openssl etc. binary
libraries. Apart from being a problem in itself, it also makes it
harder for me to review the history and possibly find other problems.
http://wstaw.org/m/2012/07/19/plasma-desktopW10725.png

* SVN usernames were replaced with full name + email address only for
the git commit Author. The Committer field still shows the SVN
username and repository UUID.

* I'm pretty sure boincadmin is David Anderson, just like boincadm.
It's currently mapped to "BOINC Administrator".

* win_build/boinc_installshield.zip is the biggest space-eater in the
repository at the moment. It's even corrupted, possibly because of EOL
conversions.

* boinc_core_release_5_9_9 is "hanging": doesn't branch off the main
history branch. In addition, it still contains openssl etc. compiled
binaries.

* The following work branches were not converted. There's only the
commits corresponding to the merges back to trunk, often doing massive
changes. You *will* regret this when you do a 'git blame' and find
code going back to the giant merge.
  - wxListCtrl port by Charlie
  - Async GUI RPCs by Charlie
  - Item property dialogs by Frank Weiler
  - Balloon notification rewrite by David Barnard
  - *Many* scheduler changes by John McLeod

* There's a lot of issues that are actually caused by bad usage of SVN
rather than a bad conversion. Even while on SVN, *please*:
  - forget about checkin_notes; use the commit message
  - don't do unrelated changes in a single commit (I can cite
thousands of examples)
  - write descriptive commit messages ("${feature} stuff" and "Quick
Updates" aren't)
  - don't list changed files in the commit message (Rom), it's
redundant since the VCS software shows that already.

-- 
Nicolás
_______________________________________________
boinc_dev mailing list
[email protected]
http://lists.ssl.berkeley.edu/mailman/listinfo/boinc_dev
To unsubscribe, visit the above URL and
(near bottom of page) enter your email address.

Reply via email to