On 1/11/13 16:58 , Rom Walton wrote: > Two reasons actually: > 1. The explicit declaration of which string class is used in the header > file reduces the chance of a namespace collision in case a project is > using more than one string class.
Sorry, I don't quite understand this one: reducing the chance for collisions should be a good thing, shouldn't it? I guess you mean implicit, right? > 2. Minimal inclusion principle as defined by David: > > CODING STYLE LAW (minimal inclusion principle): > If foo.cpp requires <blah.h>, > #include <blah.h> in foo.cpp, NOT foo.h That's correct and I agree with that. However, this is the header which requires the symbols, not the implementation. > Granted the pre-compiled header file boinc_win.h breaks #2, but the perf > gain and the fact that OS and tool chain headers rarely change is > usually enough to justify their use. Ok, fair enough. Update: the commit fixed the build. Thanks, Oliver _______________________________________________ boinc_dev mailing list [email protected] http://lists.ssl.berkeley.edu/mailman/listinfo/boinc_dev To unsubscribe, visit the above URL and (near bottom of page) enter your email address.
