On action.undo markup is broken starting from the second entry. On- site it displays as:
Version: Wed Mar 10 08:39:32 2010 Page restored to earlier version by Markus. <br /><span class=diff>No changes made</span> </form> Markus On Mar 10, 12:18 am, Markus <[email protected]> wrote: > In templates and at some other places I needed to remove lots of line > breaks. Otherwise I would end up with empty lines. Example: > > [(template first)][t][(template each)][r][c]...[(template last)][t] > [[#end]] > > The whole template must be a one-liner now. That makes it less > pleasant to work with. On the other hand I see that BoltWire is doing > what could be expected: honoring line returns. What do you think? > > One circumstance where the behavior improved is: > > <box> > text</box> > > This now gives a line return within the box as expected. But if you > want no line returns in the box, you are out of luck: > > <box>text</box> > > Will become an inline box. Maybe box should never be inline by > default. A style could make it so. > > Markus > > On Mar 9, 11:31 pm, Markus <[email protected]> wrote: > > > > > Found a missing newline in this form: > > > [form]text1 > > [text email size=35] > > text2: > > [box body rows=10]{?body}[box] > > ... > > > 'text2:' is put in the same line with [text email]. > > > Markus > > > On Mar 9, 3:43 pm, Markus <[email protected]> wrote: > > > > Happiness restored to about 105 %. Quick feedback. Quick fix. Thanks. > > > > On Mar 9, 3:12 pm, The Editor <[email protected]> wrote: > > > > > On Tue, Mar 9, 2010 at 6:47 AM, Markus <[email protected]> > > > > wrote: > > > > > Hi, > > > > > > 1) Inline display of $$actions is broken. The CSS is: > > > > > > .actions ul li { > > > > > display:inline; > > > > > } > > > > > > HTML contains <br />'s: > > > > > > <div id="wrapper"> > > > > > <div id="top"> > > > > > <div id="top0"><p><div class='actions' ><br /><br /> > > > > > <ul><li><a href="...&action=view" >view</a> <br /></li><li><a > > > > > ... some actions ... > > > > > href="...&action=print" >print</a> </div></li></ul></p></div> > > > > > My actions look fine. Could you show me the markup? Is it a snippet? > > > > Do you call it in the skin or in the top zone? Hmmm, looks like it is > > > > a problem when called via the zone... > > > > > Ok, try this and see if it fixes things for you: Insert the following > > > > to the very top of the BOLTvspacecheck function in engine.php, ~2255: > > > > > $text = str_replace(Array('<', '>'), Array('<', '>'), > > > > $text); > > > > > It seems to straighten it out for me... > > > > > > 2) One of my templates is broken. > > > > > > Template code: > > > > > > [(template first)][t] > > > > > [(template each)][r][c style="width:150px;padding:0;"]>>[(lastmodified > > > > > page={+p} fmt="%d.%m.%Y – %H:%M")]>>[c style="width:400px;padding:0;"] > > > > > [(breadcrumb {+p} offset=1 name=link)] > > > > > [(template last)][t] > > > > > [[#end]] > > > > > Ah, this was a bit tougher... Required a bit of rewriting of the > > > > template system. I think actually we would have had problems with a > > > > couple other markups in templates as well, now that I look at it more > > > > carefully... > > > > > I was able to solve this problem eventually and tidy things up a bit, > > > > but it required me to take out the "rules" and "markuptable" parameter > > > > previously available in templates. Should make things more stable, and > > > > even run a mite faster. If someone is using these, of course, I can > > > > try and find a way to reintegrate them, but I suspect nice clean html, > > > > and a more solid code base is worth it... > > > > > Cheers, > > > > Dan > > > > > P.S. I'll put out 3.4.2 here momentarily... There, it's up if you > > > > want to try again... Thanks for the quick feedback -- You received this message because you are subscribed to the Google Groups "BoltWire" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/boltwire?hl=en.
