[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051059#comment-13051059
 ] 

Flavio Junqueira commented on BOOKKEEPER-5:
-------------------------------------------

I'm not sure I understand why you're saying that PerChannelBookieClient#close 
is bypassed completely. The original trunk code only calls close on the channel 
of a PerChannelBookieClient. According to the documentation of ChannelGroup, 
calling close on it causes it to close all channels in the group. I believe the 
change I'm proposing achieves the same behavior, no?

Perhaps you're saying that we should just call awaitUninterruptibly() on every 
PerChannelBookieClient#close instead of creating a channel group? I think it 
should work.

> Issue with Netty in BookKeeper
> ------------------------------
>
>                 Key: BOOKKEEPER-5
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-5
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Assignee: Flavio Junqueira
>         Attachments: BOOKKEEPER-5.patch, BOOKKEEPER-5.patch, 
> ZOOKEEPER-998.patch
>
>
> In one my experiments, I found that a BookKeeper object was locked after I 
> tried to halt it. By searching the Web, I found that the issue is described 
> here:
> http://www.jboss.org/netty/community.html#nabble-td5492010
> I'll upload a patch to fix it. For now, I'm marking it for 3.4.0, but if 
> there is any chance we can get it in 3.3.3, it would be nice.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to