[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056443#comment-13056443
 ] 

Flavio Junqueira commented on BOOKKEEPER-5:
-------------------------------------------

On 1): According to the discussions I found online about this problem with 
Netty, if the thread is interrupted while waiting on close, then it can go into 
an infinite loop. Honestly, I didn't spend time trying to understand what 
exactly is the problem with netty, only that folks recommend to do it in the 
way we have in the patch, which makes a difference.

The real problem, though, is that we were creating new channels, but not 
keeping track of the, so when shutting down, we were not closing those channels 
and triggering the netty problem. 

I rarely have a good sense of where log messages have to be inserted, but I do 
find useful to say what we are shutting down when we call halt() in the 
BookKeeper object. Since these messages only appear when we shut down the 
object, I don't see a problem with keeping them, but at the same time I don't 
feel strongly about removing them if you feel they are unnecessary. 

> Issue with Netty in BookKeeper
> ------------------------------
>
>                 Key: BOOKKEEPER-5
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-5
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Assignee: Flavio Junqueira
>         Attachments: BOOKKEEPER-5.diff, BOOKKEEPER-5.diff, 
> BOOKKEEPER-5.patch, BOOKKEEPER-5.patch, ZOOKEEPER-998.patch
>
>
> In one my experiments, I found that a BookKeeper object was locked after I 
> tried to halt it. By searching the Web, I found that the issue is described 
> here:
> http://www.jboss.org/netty/community.html#nabble-td5492010
> I'll upload a patch to fix it. For now, I'm marking it for 3.4.0, but if 
> there is any chance we can get it in 3.3.3, it would be nice.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to