-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2642/
-----------------------------------------------------------
(Updated 2011-11-04 09:42:25.648660)
Review request for bookkeeper.
Changes
-------
attach a new patch according to Ivan's suggestions.
1) add javadoc in FileInfo to describe format of index file
2) fixed typos
3) distinguish empty master key (length is zero) from null master key. it
supports storing zero-length master key.
4) I renamed _read to readData. since we have write in FileInfo, read is much
suitable; also we don't need to change FileInfo.read in other files.
Summary
-------
save master key in header part of ledger index file.
so we can load master key when opening an existed ledger index file to avoid
that master key is null.
This addresses bug BOOKKEEPER-50.
http://issues.apache.org/jira/browse/BOOKKEEPER-50
Diffs (updated)
-----
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
1197114
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java
1197114
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BaseTestCase.java
1197114
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieReadAfterBookieRestartTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/2642/diff
Testing
-------
Thanks,
Sijie
