-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2642/
-----------------------------------------------------------
(Updated 2011-11-04 10:31:00.119933)
Review request for bookkeeper.
Changes
-------
improve the patch according to Ivan's suggestions.
1) fix typos
2) make -1 as constant define
3) change readData to readAbsolute
Summary
-------
save master key in header part of ledger index file.
so we can load master key when opening an existed ledger index file to avoid
that master key is null.
This addresses bug BOOKKEEPER-50.
http://issues.apache.org/jira/browse/BOOKKEEPER-50
Diffs (updated)
-----
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
1197481
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java
1197481
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BaseTestCase.java
1197481
http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieReadAfterBookieRestartTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/2642/diff
Testing
-------
Thanks,
Sijie