[
https://issues.apache.org/jira/browse/BOOKKEEPER-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197312#comment-13197312
]
[email protected] commented on BOOKKEEPER-157:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3696/#review4711
-----------------------------------------------------------
This patch seems to enables us to increase the number of threads, but it
doesn't actually increase it or allow an application to increase it through
configuration. Is this intentional?
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
<https://reviews.apache.org/r/3696/#comment10436>
Why do we need this synchronized block? Could you add a comment, please?
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
<https://reviews.apache.org/r/3696/#comment10434>
Why do we need this synchronized block? Could you add a comment, please?
- fpj
On 2012-01-30 15:53:51, Ivan Kelly wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3696/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-30 15:53:51)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. When benchmarking with packets smaller than 1k, performance will degrade
when the ensemble contains more than 3 bookies. See attached diagram.
bq.
bq.
bq. This addresses bug BOOKKEEPER-157.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-157
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/CRC32DigestManager.java
fb7c8bc
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
547e240
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/MacDigestManager.java
a3ed9f3
bq.
bq. Diff: https://reviews.apache.org/r/3696/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ivan
bq.
bq.
> For small packets, increasing number of bookies actually degrades performance.
> ------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-157
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-157
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-157.diff, run1.pdf, varySize.pdf
>
>
> When benchmarking with packets smaller than 1k, performance will degrade when
> the ensemble contains more than 3 bookies. See attached diagram.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
