----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3776/#review4901 -----------------------------------------------------------
Ship it! It looks good to me. +1 - Sijie On 2012-02-07 17:41:21, Ivan Kelly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3776/ > ----------------------------------------------------------- > > (Updated 2012-02-07 17:41:21) > > > Review request for bookkeeper. > > > Summary > ------- > > Add versioning in the journal so that we can add new features to the journal > without breaking backward compatibility. > > > This addresses bug BOOKKEEPER-165. > https://issues.apache.org/jira/browse/BOOKKEEPER-165 > > > Diffs > ----- > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java > 99b797f > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCache.java > 0fc5206 > > bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieJournalTest.java > PRE-CREATION > > bookkeeper-server/src/test/java/org/apache/bookkeeper/client/ClientUtil.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/3776/diff > > > Testing > ------- > > > Thanks, > > Ivan > >
