[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203627#comment-13203627
 ] 

[email protected] commented on BOOKKEEPER-165:
----------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3776/#review4901
-----------------------------------------------------------

Ship it!


It looks good to me. +1

- Sijie


On 2012-02-07 17:41:21, Ivan Kelly wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3776/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-02-07 17:41:21)
bq.  
bq.  
bq.  Review request for bookkeeper.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Add versioning in the journal so that we can add new features to the 
journal without breaking backward compatibility.
bq.  
bq.  
bq.  This addresses bug BOOKKEEPER-165.
bq.      https://issues.apache.org/jira/browse/BOOKKEEPER-165
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 
99b797f 
bq.    
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java
 PRE-CREATION 
bq.    
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCache.java 
0fc5206 
bq.    
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieJournalTest.java
 PRE-CREATION 
bq.    
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/ClientUtil.java 
PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/3776/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ivan
bq.  
bq.


                
> Add versioning support for journal files
> ----------------------------------------
>
>                 Key: BOOKKEEPER-165
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-165
>             Project: Bookkeeper
>          Issue Type: New Feature
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-165.diff, BOOKKEEPER-165.diff
>
>
> Add versioning in the journal so that we can add new features to the journal 
> without breaking backward compatibility.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to