[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212485#comment-13212485
 ] 

[email protected] commented on BOOKKEEPER-172:
----------------------------------------------------------



bq.  On 2012-02-21 06:26:00, fpj wrote:
bq.  > 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java,
 line 22
bq.  > <https://reviews.apache.org/r/3910/diff/1/?file=75146#file75146line22>
bq.  >
bq.  >     Shouldn't this go into bookkeeper.tools?

No, this accesses bookie internals. If this were put in bookkeeper.tools, then 
bookie internals would have to be made public. 


bq.  On 2012-02-21 06:26:00, fpj wrote:
bq.  > 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java,
 line 115
bq.  > <https://reviews.apache.org/r/3910/diff/1/?file=75146#file75146line115>
bq.  >
bq.  >     Sounds like we need documentation for this. It is ok if we are 
adding in BOOKKEEPER-163.

Documentation for the tool in general, or documentation for this object? This 
is the same configuration as the bookie server uses.


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3910/#review5225
-----------------------------------------------------------


On 2012-02-15 14:08:46, Ivan Kelly wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3910/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-02-15 14:08:46)
bq.  
bq.  
bq.  Review request for bookkeeper.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Part of BOOKKEEPER-163. This improvement creates a framework to allow 
administrators to upgrade the filesystem layout of previous bookkeeper versions 
to be usable by the most recent software. The upgrade processes are currently 
empty until BOOKKEEPER-163 adds something.
bq.  
bq.  
bq.  This addresses bug BOOKKEEPER-172.
bq.      https://issues.apache.org/jira/browse/BOOKKEEPER-172
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    bookkeeper-server/bin/bookkeeper b0629bd 
bq.    
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java
 PRE-CREATION 
bq.    
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/UpgradeTest.java 
PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/3910/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ivan
bq.  
bq.


                
> Upgrade framework for filesystem layouts
> ----------------------------------------
>
>                 Key: BOOKKEEPER-172
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-172
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-172.diff
>
>
> Part of BOOKKEEPER-163. This improvement creates a framework to allow 
> administrators to upgrade the filesystem layout of previous bookkeeper 
> versions to be usable by the most recent software. The upgrade processes are 
> currently empty until BOOKKEEPER-163 adds something.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to