[
https://issues.apache.org/jira/browse/BOOKKEEPER-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212503#comment-13212503
]
[email protected] commented on BOOKKEEPER-172:
----------------------------------------------------------
bq. On 2012-02-21 10:06:21, Sijie Guo wrote:
bq. >
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java,
line 68
bq. > <https://reviews.apache.org/r/3910/diff/1/?file=75146#file75146line68>
bq. >
bq. > should it be a constant define?
No, unless we define it as LAYOUT_VERSION_1 which kinda defeats the purpose. I
never what this number to be changed, so having a magic number here is fine in
my opinion.
- Ivan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3910/#review5238
-----------------------------------------------------------
On 2012-02-15 14:08:46, Ivan Kelly wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3910/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-15 14:08:46)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Part of BOOKKEEPER-163. This improvement creates a framework to allow
administrators to upgrade the filesystem layout of previous bookkeeper versions
to be usable by the most recent software. The upgrade processes are currently
empty until BOOKKEEPER-163 adds something.
bq.
bq.
bq. This addresses bug BOOKKEEPER-172.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-172
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bookkeeper-server/bin/bookkeeper b0629bd
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java
PRE-CREATION
bq.
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/UpgradeTest.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/3910/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ivan
bq.
bq.
> Upgrade framework for filesystem layouts
> ----------------------------------------
>
> Key: BOOKKEEPER-172
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-172
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-172.diff
>
>
> Part of BOOKKEEPER-163. This improvement creates a framework to allow
> administrators to upgrade the filesystem layout of previous bookkeeper
> versions to be usable by the most recent software. The upgrade processes are
> currently empty until BOOKKEEPER-163 adds something.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira